Fix legacy tests: account blocked (connection limits exceeded) #505
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ricardopereira
commented
Sep 19, 2016
| @@ -58,7 +58,8 @@ - (void)multipleSendName:(NSString *)name count:(int)count delay:(int)delay { | |||
| }]; | |||
| } | |||
| }]; | |||
| [self waitForExpectationsWithTimeout:[ARTTestUtil timeout]+delay handler:nil]; | |||
| [self waitForExpectationsWithTimeout:50.0 handler:nil]; | |||
There was a problem hiding this comment.
It seems that SocketRocket is slower than SwiftWebSocket.
Total time increased from 18s seconds to 47s.
|
LGTM |
|
Now I will see what's wrong with the Spec test suite. Will create a branch from this one. |
tcard
force-pushed
the
fix-legacy-tests-account-blocked
branch
2 times, most recently
from
7be9767 to
6ae50a1
Compare
tcard
force-pushed
the
fix-legacy-tests-account-blocked
branch
from
6ae50a1 to
e8e6836
Compare
* Test suite: add `testSuite_waitForConnectionToClose` * Fix testMultipleText_1000_10: increase timeout * A few fixes in tests. * Fix connection broken after connection is closed: should wait for the publishing acknowledgement * Fix spec tests: expects `done` completion closure to only be called once * Fix: decode each REST presence message data * Fix RSP5 * Fix: should error if authUrl request is returning incompatible data * Fix RTP8h, RTP9e, RTP10e: token with clientId * Fix RTN17e: already closed * RTC8: pending * Fix #117 test: add delay * Enhance RTP5b: wait for presence of Client2 - sometimes was passing, sometimes not * Fix InvalidNimbleAPIUsage: nested async expectations are not allowed to avoid creating flaky tests
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Executed 157 tests, with 0 failures (0 unexpected) in 108.130 (108.468) seconds