Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Invalid error field name in JSON parser #1268

Open
maratal opened this issue Jan 20, 2022 · 1 comment · May be fixed by #1269
Open

Invalid error field name in JSON parser #1268

maratal opened this issue Jan 20, 2022 · 1 comment · May be fixed by #1269
Labels
bug Something isn't working. It's clear that this does need to be fixed.

Comments

@maratal
Copy link
Collaborator

maratal commented Jan 20, 2022 •
edited by sync-by-unito bot
Loading

ARTJsonLikeEncoder tries to parse incoming error in the server's response like this:

NSDictionary *errorReason = [input valueForKey:@"errorReason"];

While in the updated implementation of the server's endpoint it's just an error as stated by Ben here - ably/specification#26

┆Issue is synchronized with this Jira Bug by Unito
@maratal maratal mentioned this issue Jan 20, 2022
Closed
@maratal maratal self-assigned this Jan 20, 2022
@maratal maratal mentioned this issue Jan 20, 2022
Closed
@maratal maratal linked a pull request Jan 20, 2022 that will close this issue
Fix/1268 push error field #1269
Draft
@maratal maratal mentioned this issue Oct 3, 2022
Open
@maratal
Copy link
Collaborator Author

maratal commented Feb 14, 2022

See discussion here #1269

@QuintinWillison QuintinWillison added bug Something isn't working. It's clear that this does need to be fixed. and removed spec-alignment labels Dec 6, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
bug Something isn't working. It's clear that this does need to be fixed.
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Fix/1268 push error field ably/ably-cocoa
4 participants
@QuintinWillison @maratal @lawrence-forooghian @AndyNicks