Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fitting decision tree on wrong data frame - cross validation intro section #52

Open
yap-alan opened this issue Aug 23, 2021 · 1 comment

Comments

@yap-alan
Copy link

yap-alan commented Aug 23, 2021

Hi, I believe there is an error in the code to fit a decision tree on the red wine quality dataset.

/# train the model on the provided features
/# and mapped quality from before
clf.fit(df_train[cols], df_test.quality)

Shouldn't the feature column be from df_train as opposed to from df_test. This error was not repeated in the longer code section where you plot accuracies for different values of max_depth

Cheers

@abhishekkrthakur
Copy link
Owner

are you reading the version downloaded from somewhere else than this repo?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants