-
Notifications
You must be signed in to change notification settings - Fork 0
/
todo
20 lines (17 loc) · 1.15 KB
/
todo
1
2
3
4
5
6
7
8
9
10
11
12
13
14
15
16
17
18
19
20
✔ Change `memory` to `calldata`. Previously, ≤ 0.6.9 `calldata` was limited to `external` function only. @done(22-05-24 20:35)
* Benefit: gas efficiency
✔ Create `apoolColl` instead of `poolColl`. And make a separate state_Var for all other pool collaterals like `spoolColl`, `dpoolColl` @done(22-05-26 14:51)
✔ *ActivePool* @started(22-05-22 16:48) @done(22-05-25 14:23)
✔ *DefaultPool* @started(22-05-26 12:30) @done(22-05-26 20:58)
✔ *Whitelist.sol* @started(22-05-30 21:31) @done(22-05-31 19:07)
☐ *BorrowerOperations* @started(22-06-01 12:54)
☐ sortedTroves, TroveManager
☐ create a diagram with ActivePool, DefaultPool with Trove @started(22-05-27 13:19)
☐ Move "CheckContract.sol" to "LibMojoDiamond.sol" file.
☐ Clear the commented state variables (already present in the .sol files)
* state vars
* using statements
☐ remove `setAddresses()` function from all the main contracts & shift to `LibMojoDiamond.sol` file.
☐ replace `msg.sender` with `_msgSender()` in all files.
// ☐ comment `stabilityPoolAddress`, stability pool wherever used - `require`, `setAddresses()`
☐ remove SP from `_requireCallerIsBOorTroveMorTMLorSP`