Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

perf: improve request pool performance for pointer types #147

Merged
merged 1 commit into from
May 22, 2023
Merged

Conversation

abemedia
Copy link
Owner

No description provided.

@codecov
Copy link

codecov bot commented May 21, 2023

Codecov Report

Patch coverage: 100.00% and no project coverage change.

Comparison is base (f1e519f) 95.87% compared to head (b9978c8) 95.87%.

❗ Current head b9978c8 differs from pull request most recent head e2f2eec. Consider uploading reports for the commit e2f2eec to get more accurate results

Additional details and impacted files
@@           Coverage Diff           @@
##           master     #147   +/-   ##
=======================================
  Coverage   95.87%   95.87%           
=======================================
  Files          23       24    +1     
  Lines         848      848           
=======================================
  Hits          813      813           
  Misses         24       24           
  Partials       11       11           
Impacted Files Coverage Δ
nilcheck.go 100.00% <100.00%> (ø)
pool.go 100.00% <100.00%> (ø)
unsafe.go 100.00% <100.00%> (ø)

☔ View full report in Codecov by Sentry.
📢 Do you have feedback about the report comment? Let us know in this issue.

@github-actions
Copy link
Contributor

github-actions bot commented May 21, 2023

Benchmark Results

.
goos: linux
goarch: amd64
pkg: github.com/abemedia/go-don
cpu: Intel(R) Xeon(R) Platinum 8272CL CPU @ 2.60GHz
                         │   before    │                after                │
                         │   sec/op    │   sec/op     vs base                │
Handler/Request-2          342.2n ± 1%   344.8n ± 1%        ~ (p=0.101 n=10)
Handler/RequestPointer-2   436.1n ± 1%   368.6n ± 1%  -15.47% (p=0.000 n=10)
geomean                    386.3n        356.5n        -7.71%

                         │   before   │                after                │
                         │    B/op    │    B/op     vs base                 │
Handler/Request-2          24.00 ± 0%   24.00 ± 0%       ~ (p=1.000 n=10) ¹
Handler/RequestPointer-2   24.00 ± 0%   24.00 ± 0%       ~ (p=1.000 n=10) ¹
geomean                    24.00        24.00       +0.00%
¹ all samples are equal

                         │   before   │                after                │
                         │ allocs/op  │ allocs/op   vs base                 │
Handler/Request-2          1.000 ± 0%   1.000 ± 0%       ~ (p=1.000 n=10) ¹
Handler/RequestPointer-2   1.000 ± 0%   1.000 ± 0%       ~ (p=1.000 n=10) ¹
geomean                    1.000        1.000       +0.00%
¹ all samples are equal

@abemedia abemedia merged commit d9464de into master May 22, 2023
@abemedia abemedia deleted the perf/pool branch May 22, 2023 21:13
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant