Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Car Dealer Clarifications #17

Open
kolbytn opened this issue Mar 12, 2024 · 5 comments
Open

Car Dealer Clarifications #17

kolbytn opened this issue Mar 12, 2024 · 5 comments

Comments

@kolbytn
Copy link

kolbytn commented Mar 12, 2024

The training data made available for Car Dealer only has 4399 instances instead of the 19K mentioned in the paper. Can you provide the complete datasets for this task?

Also, it's not clear to me how you calculate car dealer rewards based on the training dataset. The dataset provides a purchase probability at each step. Is the agent rewarded when this value reaches 100? Only at the end of the episode? Or is the purchase price weighted by the purchase probability?

Finally, when using the Car Dealer task online, the environment code provides two versions of a reward function. Which is used for evaluation and online training in the paper?

@icwhite
Copy link
Collaborator

icwhite commented Mar 12, 2024

The reward function specified as "fancy" is used for online evaluation. In the offline dataset, the reward is assigned at the end of the episode and is not weighted by the purchase probability.

We will update the dataset on the server. Thank you for bringing this to our attention.

@icwhite icwhite closed this as completed Mar 12, 2024
@kolbytn
Copy link
Author

kolbytn commented Mar 12, 2024

Thank you! For now, is there a purchase probability threshold that I can use to determine a purchase?

@kolbytn
Copy link
Author

kolbytn commented Mar 12, 2024

Also, Table 4 in the paper looks like it might be using revenue in thousands as a reward (although my attempt to reproduce results were in the 20Ks as opposed to the 50Ks). Can you provide the results from Table 4 using the "fancy" reward instead? Or clarify how the results in Table 4 were obtained for car dealer?

@icwhite icwhite reopened this Mar 12, 2024
@arpaiva
Copy link
Contributor

arpaiva commented Jun 26, 2024

@icwhite - You mentioned above that the car-dealer data would be updated in the server. Any idea when that will be done?

@icwhite
Copy link
Collaborator

icwhite commented Jul 2, 2024

Sorry, I don't know. @abdulhaim would you be able to respond with the complete dataset?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants