Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

resholve Nix API mangling package meta #86

Closed
abathur opened this issue Sep 12, 2022 · 1 comment
Closed

resholve Nix API mangling package meta #86

abathur opened this issue Sep 12, 2022 · 1 comment

Comments

@abathur
Copy link
Owner

abathur commented Sep 12, 2022

It looks like the resholve builders are holding something wrong and it's throwing off how resholved packages' meta.position is set.

I suspect I need to pull at least .meta in from the initial package.

The sources button led to https://github.com/NixOS/nixpkgs/blob/nixos-unstable/pkgs/development/misc/resholve/resholve-utils.nix#L181 on nixpkgs search, so I got confused

Originally posted by @Samisafool in NixOS/nixpkgs#190800 (comment)
@abathur abathur changed the title The sources button led to https://github.com/NixOS/nixpkgs/blob/nixos-unstable/pkgs/development/misc/resholve/resholve-utils.nix#L181 on nixpkgs search, so I got confused resholve mangling package meta Sep 12, 2022
@abathur abathur changed the title resholve mangling package meta resholve Nix API mangling package meta Sep 12, 2022
@abathur
Copy link
Owner Author

abathur commented Sep 13, 2022

I've opened NixOS/nixpkgs#191003 to tentatively address this in Nixpkgs. Once it's clear that approach is acceptable there, I'll make an ~identical commit here to close this issue.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@abathur