Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Replace deprecated imp module with importlib #19

Closed
hugovk opened this issue Apr 29, 2023 · 2 comments
Closed

Replace deprecated imp module with importlib #19

hugovk opened this issue Apr 29, 2023 · 2 comments

Comments

@hugovk
Copy link

hugovk commented Apr 29, 2023

This project uses the imp module which has been deprecated since Python 3.4 and removed in 3.12:

Python 3.12 is set for release on 2023-10-02 and this library is one of the top 5,000 most-downloaded from PyPI.

Please could you upgrade to use importlib? The imp docs have suggestions on what to use to replace each function and constant.

@abarker
Copy link
Owner

abarker commented Apr 30, 2023

That module is old and is only imported in strip_hints_main if Python 2 is detected. Otherwise the import_hooks_py3 module is imported. The latter uses importlib, and has for some time.

@hugovk
Copy link
Author

hugovk commented Apr 30, 2023

Sounds good, then nothing to do here. Thanks!

@hugovk hugovk closed this as not planned Won't fix, can't repro, duplicate, stale Apr 30, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants