Docker support

[filips123]

I've added basic support for Docker. It is part of the fix for #27. That issue should still be opened because it is still not completed.

It is now possible to run the website with docker-compose up. It contains several containers for PHP, Ruby, SQL and Redis.

---

After cloning the repo, users should copy lib/config.docker.php to lib/config.php (and not edit it). That file loads config from environment variables.

Then, they should copy .env.sample to .env and provide configuration.

They can then start all containers with docker-compose up.

---

This has some problems.

The database is empty. Even if table schema is added at first run, tables will be empty. And this is a problem because the client_id would not be registered. There should be some admin website or console command to add clients.

Also, documentation is not finished. It needs to be finished after all other problems are fixed.

And all functionality needs to be tested because I didn't have time to do this completely.

[Lewiscowles1986]

Isn't this self-defeating to make the values globally available twice?

[filips123]

This is only easy option.

You can't set static properties dynamically with function call so I have to first save them into constants.

But it may also work with normal variables instead of constants.

[Lewiscowles1986]

This is only easy option.

I think putting the argument in the connection utility fits better with a heroku + docker (12-factor) deployment.

[filips123]

I think putting the argument in the connection utility fits better with a heroku + docker (12-factor) deployment.

Can you explain this a bit more?

[Lewiscowles1986]

So instead of having config be the source for all things, you could instead build an interface and have multiple implementations that fulfil that interface to provide details.

A Lighter weight option that does similar would be using null coalesce operator, leaving the config as null, and Config::$value ?? ENV['ENV_VAR1'] ?? ENV['ENV_VAR2'];

http://sandbox.onlinephpfunctions.com/code/22d382de6f0128a63d11ba37b79a4c7d3faad57a is a trivial example

[filips123]

It is now setting properties directly from env vars. It doesn't need null coalesce operator, because env vars need to be set anyway.

[Lewiscowles1986]

I think there has been confusion about my meaning.

Also blank string is not really the best option.

null specifically says "unknown"

[Lewiscowles1986]

I've made a PR which I think explains what I think is a better approach to ENV based configuration. It was what I was trying to explain to you.

Basically there should be no need for Config in environments such as Docker