Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Unrecognized GitHub link with trailing "/" #59

Open
szpak opened this issue Mar 6, 2020 · 6 comments
Open

Unrecognized GitHub link with trailing "/" #59

szpak opened this issue Mar 6, 2020 · 6 comments

Comments

@szpak
Copy link

szpak commented Mar 6, 2020

The following link:

<link href="https://github.com/nonexistingone/" rel="me">

is found and displayed by indielogin.com, but is not recognized as GitHub. With the trailing / removed it works.

Maybe matching with URLs could be extended to accept trailing /. They are valid links to those services.

Similar to #16, but different.

@aaronpk
Copy link
Owner

aaronpk commented Jan 9, 2021

Can you try again? I just pushed some changes that should solve this.

@szpak
Copy link
Author

szpak commented Jan 10, 2021

I will try to check it doing the next update on my blog. If you think it should be fixed, let's close this issue. I will reopen it when needed.

Thanks for taking a look at that.

@szpak szpak closed this as completed Jan 10, 2021
@robindotis
Copy link

Just to let you know, this is still an issue. I have two sites using webmention.io. On one the "rel=me" link ended with a slash, on the other not. The one with a trailing slash was not recognised as github. indielogin found the rel link, but told me it was not a valid authentication provider. Was a little confusing, but thanks to reading this issue I removed the trailing slash and now it works.

Maybe re-open the issue?

@aaronpk aaronpk reopened this Jan 22, 2021
@missmatsuko
Copy link

missmatsuko commented May 4, 2021

Login error message

Your GitHub profile linked to https://www.matsuko.ca/ but we were expecting to see https://www.matsuko.ca/. Make sure you link to https://www.matsuko.ca/ in your GitHub profile.

I had the same problem. Removing the trailing slash worked.

Would it be possible to not requiring specify the protocol as well, or would that cause issues? I kind of like having just www.matsuko.ca on my GitHub profile but I had to add https:// to authenticate for this.

@lauras
Copy link

lauras commented Apr 7, 2023

I'm having the same problem trying to log in using GitHub. I tried with two different websites linked in my GitHub profile (and linked back from the sites fwiw), but I just get an error:

GitHub profile links to [A] but we were expecting to see [A]. Make sure you link to [A] in your GitHub profile.

…which only leaves me mystified. I even tried adding the trailing slash, but that made no difference.

@lauras
Copy link

lauras commented Apr 7, 2023

Actually I have to correct my post above because I'm realizing that none of my profile links are seen, if I'm reading this error text right.
Screenshot of SafariScreenshot of Safari (4-7-23, 2-41-02 PM)
Screenshot of SafariScreenshot of Safari (4-7-23, 2-43-18 PM)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

5 participants