-
Notifications
You must be signed in to change notification settings - Fork 25
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Unrecognized GitHub link with trailing "/" #59
Comments
Can you try again? I just pushed some changes that should solve this. |
I will try to check it doing the next update on my blog. If you think it should be fixed, let's close this issue. I will reopen it when needed. Thanks for taking a look at that. |
Just to let you know, this is still an issue. I have two sites using webmention.io. On one the "rel=me" link ended with a slash, on the other not. The one with a trailing slash was not recognised as github. indielogin found the rel link, but told me it was not a valid authentication provider. Was a little confusing, but thanks to reading this issue I removed the trailing slash and now it works. Maybe re-open the issue? |
I had the same problem. Removing the trailing slash worked. Would it be possible to not requiring specify the protocol as well, or would that cause issues? I kind of like having just |
I'm having the same problem trying to log in using GitHub. I tried with two different websites linked in my GitHub profile (and linked back from the sites fwiw), but I just get an error:
…which only leaves me mystified. I even tried adding the trailing slash, but that made no difference. |
The following link:
is found and displayed by indielogin.com, but is not recognized as GitHub. With the trailing
/
removed it works.Maybe matching with URLs could be extended to accept trailing
/
. They are valid links to those services.Similar to #16, but different.
The text was updated successfully, but these errors were encountered: