Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Syndication link not displaying #46

Open
gRegorLove opened this issue May 8, 2020 · 1 comment
Open

Syndication link not displaying #46

gRegorLove opened this issue May 8, 2020 · 1 comment

Comments

@gRegorLove
Copy link

This post has a syndication link to goodreads.com that is not displaying currently. Below is the Monocle debug for the post.

May be related to the author information not being parsed. The missing author should resolve once Aperture gets the latest version of XRay, though.

{
    "type": "entry",
    "published": "2020-05-07 22:39-0700",
    "url": "https://gregorlove.com/2020/05/currently-reading-youre-a/",
    "syndication": [
        "https://www.goodreads.com/review/show/3324627020"
    ],
    "content": {
        "text": "Currently reading: You're a Miracle (And a Pain in the Ass): Embracing the Emotions, Habits, and Mystery That Make You You by Mike McHargue (ISBN 9781984823243)",
        "html": "<p>Currently reading: <span class=\"p-read-of h-cite\"><a class=\"u-url\" href=\"https://gregorlove.com/isbn/9781984823243\">You're a Miracle (And a Pain in the Ass): Embracing the Emotions, Habits, and Mystery That Make You You</a> by <span class=\"p-author\">Mike McHargue</span> (ISBN <span class=\"p-uid\">9781984823243</span>)</span></p>"
    },
    "post-type": "note",
    "_id": "11405979",
    "_source": "95",
    "_is_read": false
}
@gRegorLove
Copy link
Author

Took a fresh look at this and noticed the goodreads link is there, with an SVG inside, but it's not visible.

<a href="https://www.goodreads.com/review/show/3324627020" class="u-syndication"><svg class="svg-icon" style="
    background: red;
"><use xlink:href="/assets/font-awesome-5.11.2/brands.svg#link"></use></svg></a>

https://monocle.p3k.io/assets/font-awesome-5.11.2/brands.svg doesn't appear to define #link

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant