Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Scope parameter forgotten if "me" is not included #215

Open
tomlarkworthy opened this issue Apr 8, 2021 · 0 comments
Open

Scope parameter forgotten if "me" is not included #215

tomlarkworthy opened this issue Apr 8, 2021 · 0 comments

Comments

@tomlarkworthy
Copy link

tomlarkworthy commented Apr 8, 2021

If the "me" parameter is not included the site will serve the sign_in chooser at the beginning of the auth flow and then redirect the user back to /auth. However, after the user chooses their identify URL in sign_in the original scope parameter is not forwarded.

If "me" is nil hydrate signin-form

https://github.com/aaronpk/IndieAuth.com/blob/main/controllers/auth-web.rb#L188

  1. If me is not nil read the "scope" param

https://github.com/aaronpk/IndieAuth.com/blob/main/controllers/auth-web.rb#L217

  1. Note: the signing form does not have a scope parameter

<form action="<%= SiteConfig.root %>/auth" method="get" class="well" style="margin: 20px 0;">

can be reprod with https://observablehq.com/@tomlarkworthy/weblogin

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant