Add barebones duckDB reporter #75
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
maxmynter
approved these changes
Feb 12, 2024
nicholasjng
force-pushed
the
extend-reporter-interface
branch
from
86cf1ff
to
71eefb4
Compare
They are not directly useable for descendants, which might have their own display options, so they move into the class API. Also extends the read/write interfaces to variadic generics to make subclassing easier for now until the interface stands.
Implements a polymorphic read/write facility via a simple backend abstraction. A backend here is a pair of serialization and deserialization callbacks with a strict interface. Starting backends are JSON, CSV (untested), and YAML (untested). Currently, the choice of inlining context vs. saving only the two top level keys is not given, which results in errors when trying to read records with duckDB. This will be addressed in a follow-up.
This is a bit of a misnomer, since the class is currently just a file reporter with some extra filtering facilities. To improve, we need to open up a SQL query builder facility to actually obtain analytics from the database without too much effort. In that light, it may be beneficial to outsource this part of the process if supporting all relevant SQL features turns out to be too cumbersome.
nicholasjng
force-pushed
the
extend-reporter-interface
branch
from
832bb72
to
a8311e2
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Implements a polymorphic read/write facility via a simple backend
abstraction. A backend here is a pair of serialization and deserialization
callbacks with a strict interface.
Starting backends are JSON, CSV (untested), and YAML (untested).
Currently, the choice of inlining context vs. saving only the two top
level keys is not given, which results in errors when trying to read
records with duckDB. This will be addressed in a follow-up.
Add barebones duckDB reporter
This is a bit of a misnomer, since the class is currently just a file
reporter with some extra filtering facilities. To improve, we need to
open up a SQL query builder facility to actually obtain analytics from
the database without too much effort.
In that light, it may be beneficial to outsource this part of the process
if supporting all relevant SQL features turns out to be too cumbersome.