Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add Parameters to Benchmarks #103

Merged
merged 5 commits into from
Mar 10, 2024
Merged

Add Parameters to Benchmarks #103

merged 5 commits into from
Mar 10, 2024

Commits on Mar 8, 2024

  1. Add Parameters to Benchmarks 

    Add the Parameters to a 'BenchmarkRecord' by appending it to the results.
Omit the type information from the `Variable` object and only retain variable
name and value.
    @maxmynter
    maxmynter committed Mar 8, 2024
    Configuration menu
    Copy the full SHA
    a130498 View commit details
    Browse the repository at this point in the history

  2. Update Readme to include parameter summary 

    rdme
    @maxmynter
    maxmynter committed Mar 8, 2024
    Configuration menu
    Copy the full SHA
    bf72378 View commit details
    Browse the repository at this point in the history

  3. Add test for filtering via parameters

    @maxmynter
    maxmynter committed Mar 8, 2024
    Configuration menu
    Copy the full SHA
    70dde07 View commit details
    Browse the repository at this point in the history

  4. Update src/nnbench/runner.py 

    Co-authored-by: Nicholas Junge <[email protected]>
    @maxmynter @nicholasjng
    maxmynter and nicholasjng authored Mar 8, 2024
    Configuration menu
    Copy the full SHA
    525ddea View commit details
    Browse the repository at this point in the history

Commits on Mar 10, 2024

  1. Inline benchmark into test, use update syntax on dict 

    What's left is to decide what to do with parameter types that aren't as
easily ingestible into a sink as builtin datatypes.
    @nicholasjng
    nicholasjng committed Mar 10, 2024
    Configuration menu
    Copy the full SHA
    0c0a107 View commit details
    Browse the repository at this point in the history