Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Hint all name arguments as str only #132

Closed
nicholasjng opened this issue Mar 26, 2024 · 1 comment · Fixed by #135
Closed

Hint all name arguments as str only #132

nicholasjng opened this issue Mar 26, 2024 · 1 comment · Fixed by #135
Assignees
@maxmynter
Labels
refactor Makes existing code nicer and more useable.

Comments

@nicholasjng
Copy link
Collaborator

Currently, we hint name: str | None on the benchmark name, which is bad practice. Names of benchmarks can realistically never be None, and are overwritten immediately with the function name in the post-init.

We were going to add this in the State PR, but realized that the changeset is going to be too big, since all decorator call sites will also have to be changed. So we're leaving this for a follow-up.
@nicholasjng nicholasjng added the refactor Makes existing code nicer and more useable. label Mar 26, 2024
@nicholasjng
Copy link
Collaborator Author

Fixed in #135.

@Maciej818 Maciej818 linked a pull request Mar 28, 2024 that will close this issue
Organize nnbench.types.types into different files #135
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@maxmynter maxmynter

Labels
refactor Makes existing code nicer and more useable.
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Organize nnbench.types.types into different files aai-institute/nnbench
2 participants
@maxmynter @nicholasjng