Both options on importing save data do the same thing

[drinfernoo]

When importing save data, both options make you go through the list and choose for each one.

[drinfernoo]

It appears that each option functions as intended, but if you choose "No Ask", files get replaced no matter what you choose.

[drinfernoo]

This is in the method manageSaveData on line 2097 in default.py.

[drinfernoo]

@irbyjm, any progress?

[irbyjm]

@drinfernoo I might have had this fixed in an earlier commit but then dumped it because I misinterpreted what was supposed to happen. Can you validate my thought process?

Is it supposed to:

• Ask if you want to overwrite
• If yes, completely overwrite the file (then regex replace with traktIt('restore'))
• If no, only regex replace?

I am still wrapping my head around default.py's

                shutil.copy(temp, old)
            traktit.importlist('all')
            traktit.traktIt('restore', 'all')

traktit.py's traktIt()

					if user == '' and do == 'update': continue
					updateTrakt(do, log)

and traktit.py's updateTrakt()

	elif do == 'restore':

Which looks like no matter what you choose for overwrite, traktIt() tells updateTrakt() to do a restore. But I've been doing a watch ls to look for file modification, not thinking about the scenario that the file doesn't get overwritten but a regex happens anyway (which causes mtime to change).

[drinfernoo]

I need to dig into it more as well, as I'm not exactly sure how it's supposed to work, but that's my understanding as well.

[drinfernoo]

This is the relevant code related to Trakt importing, from default.py.

https://github.com/drinfernoo/plugin.program.aftermath/blob/6001f3c5f069665c1013ca392974e2581567813c/default.py#L2124-L2139

It appears that what this does is: on line 2129, loops through all the files in the temp/trakt folder, and on line 2137, copies them in regardless of whether overwrite (from line 2124) is even set or not. Then, on lines 2137-2138, it imports all of the files into the wizard, and updates all of the saved data.

If we can fix this for Trakt, we can also fix it for debrid and login saving, since the code is identical.

[drinfernoo]

This will hopefully become simpler if modular add-on support is implemented, as mentioned in #32.

[drinfernoo]

Closed for inactivity. Much of this code is outdated and needs to be fixed up anyways.