Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Make facebook tags clickable #176

Closed
pyrog opened this issue May 13, 2022 · 5 comments
Closed

Make facebook tags clickable #176

pyrog opened this issue May 13, 2022 · 5 comments
Labels
bug Something isn't working editor Editor pane, presets and fields
Milestone
0.4

Comments

@pyrog
Copy link

pyrog commented May 13, 2022 •
edited
Loading

A click on website open the URL, but not for contact:facebook, contact:instagram…

Note: accept also facebook (in fact all common tags with or without contact: prefix)
@pyrog pyrog changed the title Make facebook tags clicable Make facebook tags clickable May 13, 2022
@pyrog
Copy link
Author

pyrog commented May 13, 2022

See also #178

@Zverik
Copy link
Owner

Zverik commented May 13, 2022

They are already clickable. If you found one that isn't, please link the object.

@Zverik Zverik closed this as completed May 13, 2022
@pyrog
Copy link
Author

pyrog commented May 13, 2022 •
edited
Loading

For example : https://www.openstreetmap.org/node/7495152594
contact:facebook=PauseRelaxante should open https://www.facebook.com/PauseRelaxante

Regex should work for PauseRelaxante, but not for i.e. https://www.facebook.com/ruspost (see https://regexr.com/6ljbj).

@Zverik
Copy link
Owner

Zverik commented May 13, 2022

Yeah, indeed. Thanks.

@Zverik Zverik reopened this May 13, 2022
@Zverik Zverik added bug Something isn't working editor Editor pane, presets and fields labels May 13, 2022
@Zverik Zverik added this to the 0.4 milestone May 13, 2022
@Zverik Zverik moved this to Todo in Every Door May 13, 2022
@Zverik Zverik moved this from Todo to Done in Every Door May 21, 2022
@Zverik
Copy link
Owner

Zverik commented May 21, 2022

Done in 0.4.

@Zverik Zverik closed this as completed May 21, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
bug Something isn't working editor Editor pane, presets and fields
Projects
Every Door
Status: Done
Milestone
0.4
Development

No branches or pull requests
2 participants
@Zverik @pyrog