api:fix - Error when not exists analysis in database #583
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
wiliansilvazup
force-pushed
the
hotfix/horusec-api
branch
from
74bb5c0
to
c4b9f8b
Compare
wiliansilvazup
requested review from
lucasbrunozup,
nathanmartinszup,
iancardosozup,
matheusalcantarazup and
oliveirafelipezup
as code owners
When not exists analysis in database, I founded this problem. And for solution it was necessary change this logic for check if not exists hashes deprecated. Other problem resolved here was about the responsability of the methods, them I change all code with database logic to repositories layer and stay only business logic into controllers layer. Signed-off-by: Wilian Gabriel <[email protected]>
wiliansilvazup
force-pushed
the
hotfix/horusec-api
branch
from
c4b9f8b
to
611f09a
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When not exists analysis in database, I founded this problem.
And for solution it was necessary change this logic for check if
not exists hashes deprecated. Other problem resolved here was
about the responsability of the methods, them I change all code
with database logic to repositories layer and stay only business logic
into controllers layer.
Signed-off-by: Wilian Gabriel [email protected]