Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

auth:chore - Keycloak decode token to get accountID. #538

Merged
merged 2 commits into from
Jan 13, 2022

Conversation

lucasbrunozup
Copy link
Contributor

When the auth verify the user permission, the current code
called keycloak server for get accountID, and this can be
considered a DDos attack for keycloak.

I change the function for the decode the accessToken and
get the accountID from this.

Signed-off-by: lucas.bruno [email protected]

…JWTToken

call the keycloak server on all requests for backend and this can be
considered a DDos attack for keycloak.

Signed-off-by: lucas.bruno <[email protected]>
@gitguardian
Copy link

gitguardian bot commented Jan 12, 2022

⚠️ GitGuardian has uncovered 1 secret following the scan of your pull request.

Please consider investigating the findings and remediating the incidents. Failure to do so may lead to compromising the associated services or software components.

🔎 Details of the secret
Secret Commit Filename Detected At
Generic High Entropy Secret bbad3ba auth/internal/services/authentication/keycloak/client/keycloak_test.go 12:45 January 12th, 2022 View secret
🛠 Guidelines to remediate hardcoded secrets
  1. Understand the implications of revoking this secret by investigating where it is used in your code.
  2. Replace and store your secret safely. Learn here the best practices.
  3. Revoke and rotate this secret.
  4. If possible, rewrite git history. Rewriting git history is not a trivial act. You might completely break other contributing developers' workflow and you risk accidentally deleting legitimate data.

To avoid such incidents in the future consider

GitGuardian is an automated secrets detection service.We help developers and security teams secure the modern software development process.

 

Our GitHub checks need improvements? Share your feedbacks

@wiliansilvazup wiliansilvazup merged commit 9c1615c into main Jan 13, 2022
@wiliansilvazup wiliansilvazup deleted the feature/keycloack-token-decode branch January 13, 2022 16:00
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants