This repository has been archived by the owner on Jun 1, 2024. It is now read-only.
fix list view id #258
Closed
fix list view id #258
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jamessonpenhazup
requested review from
arthurbleilzup,
arthurribeirozup,
carolinegoncalveszup,
evertonrodrigueszup,
hectorcustodiozup,
magnolemoszup,
pedronaveszup,
rafamsilva,
tarcisiogc,
tayronemachadozup and
Tiagoperes
as code owners
arthurbleilzup
approved these changes
May 11, 2021
Tiagoperes
suggested changes
May 14, 2021
There was a problem hiding this comment.
As discussed with @arthurbleilzup, we should do a very simple work around for now and wait for Beagle 2.0, where this problem won't exist any longer.
Workaround: before assigning the ids, replace every child: element with children: [element].
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
- What I did
Fix list view id.
- How I did it
Running the pre process for each item in the list generating the id.
- How to verify it
Test with This example, uses an image inside a touchable in the template of a list view: https://playground.usebeagle.io/#/cloud/S3-b213d4c3-31b2-4f03-a4e0-e6cdbabb75c3?platform=angular
- Description for the changelog
Closes #251