From 9d6748693b9e4f8388cf2c70846d7c906a785c57 Mon Sep 17 00:00:00 2001 From: Tom Burrows Date: Tue, 31 Mar 2020 02:06:56 +0100 Subject: [PATCH 1/3] Update PR template. Add new 'Unreleased' section to CHANGELOG.md. --- .github/PULL_REQUEST_TEMPLATE.md | 12 ++++++------ CHANGELOG.md | 26 ++++++++++++++++++++++++-- setup.py | 2 +- 3 files changed, 31 insertions(+), 9 deletions(-) diff --git a/.github/PULL_REQUEST_TEMPLATE.md b/.github/PULL_REQUEST_TEMPLATE.md index 9dca452bd..92f3fdd4d 100644 --- a/.github/PULL_REQUEST_TEMPLATE.md +++ b/.github/PULL_REQUEST_TEMPLATE.md @@ -2,9 +2,9 @@ Please tick when you have done these. They don't need to all be completed before the PR is created. Delete them if they are not appropriate for this pull request. --> -- [ ] I have provided code that clearly demonstrates the bug and only works correctly when used with this PR -- [ ] I have added suitable tests to the test suite in `tests/` -- [ ] I have properly documented new or changed features in the documention or in the docstrings -- [ ] I have properly documented unusual changes to the code in the comments around it -- [ ] I have made note of any breaking/backwards incompatible changes -- [ ] I formatted my code using `black -t py36` \ No newline at end of file +- [ ] I have provided code that clearly demonstrates the bug and that only works correctly when applying this fix +- [ ] I have added suitable tests demonstrating a fixed bug or new/changed feature to the test suite in `tests/` +- [ ] I have added a suitable explanation of the change to `CHANGELOG.md` +- [ ] I have properly documented new or changed features in the documentation or in the docstrings +- [ ] I have properly explained unusual or unexpected code in the comments around it +- [ ] I have formatted my code using `black -t py36` \ No newline at end of file diff --git a/CHANGELOG.md b/CHANGELOG.md index 60e70db2c..736726c09 100644 --- a/CHANGELOG.md +++ b/CHANGELOG.md @@ -1,5 +1,27 @@ # Changelog +All notable changes to this project will be documented in this file. + +The format from v2.0.0 onwards is based on [Keep a Changelog](https://keepachangelog.com/en/1.0.0/), +and this project adheres to [Semantic Versioning](https://semver.org/spec/v2.0.0.html). + +## [Unreleased](https://github.com/zulko/moviepy/tree/master) +### Important Announcements +- Support removed for Python versions 2.7, 3.4 & 3.5 [#1103, #1106] + +### Added + +### Changed + +### Deprecated + +### Removed +- Support removed for Python versions 2.7, 3.4 & 3.5 + +### Fixed +- When using `VideoClip.write_videofile()` with `write_logfile=True`, errors would not be properly reported [#890] + + ## [v1.0.2](https://github.com/zulko/moviepy/tree/v1.0.2) (2020-03-26) [Full Changelog](https://github.com/zulko/moviepy/compare/v1.0.1...v1.0.2) @@ -8,8 +30,8 @@ Note that this is likely to be the last release before v2.0, which will drop sup **Notable bug fixes:** -- Fixed bug that meant that some VideoFileClips were created without audio [\#968] -- Fixed bug so now the `slide_out` effect works [\#795] +- Fixed bug that meant that some VideoFileClips were created without audio [\#968](https://github.com/Zulko/moviepy/pull/968) +- Fixed bug so now the `slide_out` effect works [\#795](https://github.com/Zulko/moviepy/pull/795) **Fixed bugs:** diff --git a/setup.py b/setup.py index 39d1c10f2..ad58ecef3 100644 --- a/setup.py +++ b/setup.py @@ -58,7 +58,7 @@ def run_tests(self): from sphinx.setup_command import BuildDoc except ImportError: raise ImportError( - "Running the documenation builds has additional" + "Running the documentation builds has additional" " dependencies. Please run (pip install moviepy[docs])" ) From 9b3d813f6f3a85135294de3c084d5cc280bf789e Mon Sep 17 00:00:00 2001 From: Tom Burrows Date: Tue, 31 Mar 2020 02:15:01 +0100 Subject: [PATCH 2/3] Add 'Full Changelog' link --- CHANGELOG.md | 4 ++++ 1 file changed, 4 insertions(+) diff --git a/CHANGELOG.md b/CHANGELOG.md index 736726c09..96b7502ce 100644 --- a/CHANGELOG.md +++ b/CHANGELOG.md @@ -6,6 +6,10 @@ The format from v2.0.0 onwards is based on [Keep a Changelog](https://keepachang and this project adheres to [Semantic Versioning](https://semver.org/spec/v2.0.0.html). ## [Unreleased](https://github.com/zulko/moviepy/tree/master) + +[Full Changelog](https://github.com/zulko/moviepy/compare/v1.0.2...HEAD) + + ### Important Announcements - Support removed for Python versions 2.7, 3.4 & 3.5 [#1103, #1106] From e997afa0070711d6a90bde3ca38f3b50f04084f9 Mon Sep 17 00:00:00 2001 From: Tom Burrows Date: Wed, 1 Apr 2020 12:43:27 +0100 Subject: [PATCH 3/3] Remove requirement to update changelog from PR template. --- .github/PULL_REQUEST_TEMPLATE.md | 3 +-- 1 file changed, 1 insertion(+), 2 deletions(-) diff --git a/.github/PULL_REQUEST_TEMPLATE.md b/.github/PULL_REQUEST_TEMPLATE.md index 92f3fdd4d..1784a1dc2 100644 --- a/.github/PULL_REQUEST_TEMPLATE.md +++ b/.github/PULL_REQUEST_TEMPLATE.md @@ -1,10 +1,9 @@ - [ ] I have provided code that clearly demonstrates the bug and that only works correctly when applying this fix - [ ] I have added suitable tests demonstrating a fixed bug or new/changed feature to the test suite in `tests/` -- [ ] I have added a suitable explanation of the change to `CHANGELOG.md` - [ ] I have properly documented new or changed features in the documentation or in the docstrings - [ ] I have properly explained unusual or unexpected code in the comments around it - [ ] I have formatted my code using `black -t py36` \ No newline at end of file