Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add final check digit validation in SlovakId2_34 #10

Open
ZsBT opened this issue May 29, 2017 · 4 comments
Open

add final check digit validation in SlovakId2_34 #10

ZsBT opened this issue May 29, 2017 · 4 comments
Labels

Comments

@ZsBT
Copy link
Owner

ZsBT commented May 29, 2017

final check digit validation is missing from SlovakId2_34 :: fromMrz()
can someone please fix this

@GoUpNorth
Copy link
Contributor

The slovak id card seems to fit the ICAO mrtd1 specifications, which the library already supports.
I don't have any issue with other mrtd1 documents such as chile id card or albanian card.

@ZsBT
Copy link
Owner Author

ZsBT commented Sep 14, 2017

Were you able to test a Slovak ID card (unfortunately I don't have any)? If follows the standards, we could just comment it out and let the base mrtd1 class to parse it.

@GoUpNorth
Copy link
Contributor

You can find a sample of a recent slovak id card on this website:

However, on the same website you can find an older id card sample from the beginning of the 90s (http://www.consilium.europa.eu/prado/en/SVK-BO-01001/index.html), which does not seem to be ICAO compliant. I imagine that's the one the class SlovakId2_34 is referring to.
I couldn't find any english specifications describing the content of its MRZ and the check digits calculation.

But if it can make you feel better, this document was last issued in 2008 (the year in which this one was first issued http://www.consilium.europa.eu/prado/en/SVK-BO-02001/index.html) and its maximum validity is 10 years. So from 2018, those non ICAO documents won't be used anymore.

P-A

@ZsBT ZsBT removed the help wanted label Sep 15, 2017
@ZsBT
Copy link
Owner Author

ZsBT commented Sep 15, 2017

Good finding, we'll just remove this type due to obsolete documents.

@ZsBT ZsBT added wontfix and removed enhancement labels Sep 15, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

2 participants