Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Regular user cannot create or access groups #541

Closed
barjac opened this issue Oct 24, 2014 · 8 comments
Closed

Regular user cannot create or access groups #541

barjac opened this issue Oct 24, 2014 · 8 comments

Comments

@barjac
Copy link
Contributor

barjac commented Oct 24, 2014

I'm under the impression that this feature (groups) is intended to be accessible to all web users, however testing in 1.28.0 it seems that the groups feature is only visible in the UI to admins with system edit rights.

Can this be changed so that any user can set his/her own groups for monitoring?

@knight-of-ni
Copy link
Member

Here is what I currently see in groups.php.

In order to view the "Groups" view, one must have canView( 'System' ) permission assigned to them under Options -> User

In addition to that, the New, Edit, and Delete buttons require additional canEdit('System') permission.
The Apply and Cancel buttons do not have any permission associated directly with them.

This sounds reasonable to me, but I've never used groups before. Is there some reason why you don't want to give the canView( 'System' ) permission to your users? Is there an existing permission that might work better? canView( 'Monitor ' ) perhaps?

Note that since this is php script, you can easily experiment with this and modify your groups.php file to find what permission might work better.

@connortechnology
Copy link
Member

I don't see any reason to restrict the group filtering. I intend to make it available to all, subject of course, to user <=> monitor restrictions.

@barjac
Copy link
Contributor Author

barjac commented Oct 25, 2014

Thanks - that sounds good :)

@knight-of-ni
Copy link
Member

Didn't @connortechnology previously fix this, or do I mis-remember?

@connortechnology
Copy link
Member

I did do something, but I can't find it now. Must have just committed it instead of doing a PR. I think barjac wanted more.

@barjac
Copy link
Contributor Author

barjac commented Aug 14, 2015

IIRC you made it so that normal users could access groups previously set by an admin, but not set them up. I thought that regular users should be able to set up their own groups.

@knight-of-ni
Copy link
Member

@barjac what say ye? Can we close this or is there more work to be done?

UPDATE: I see your response

@barjac
Copy link
Contributor Author

barjac commented Aug 14, 2015

I have not rebuilt recently so no idea how it is at present. Mageia 5 was in freeze for months :\ I still think as above. If a user just wants to group a few monitors together for a montage they should be able to do that.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants