Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

"Stacking" Event Notifications(Android). #85

Closed
eekay35 opened this issue Feb 24, 2019 · 10 comments
Closed

"Stacking" Event Notifications(Android). #85

eekay35 opened this issue Feb 24, 2019 · 10 comments
Labels

Comments

@eekay35
Copy link

eekay35 commented Feb 24, 2019

First, thank you very much for your hard work on all your ZM stuff! It is hands down the best 3rd party/add-on ZM software out there! Fantastic work! With that being said, this isn't an issue, but more of a feature request or wondering if it's already being worked on as it seems to be something that's pretty standard with any notification (on Android, anyway) and it would be very helpful to see dates, times, photos, etc... of all the notifications I'm receiving instead of just one.

As the topic (hopefully?) suggests, I'm wondering if there is a way to have the notifications I'm getting be "stacked" so I can see all the notifications I've received (maybe via pull-down like a text message notification) as opposed to just the very latest. It seems that right now each notification I get just kicks the previous notification out of the way and replaces it. While this is most certainly better than no notification at all, sometimes I'll get multiple notifications while I'm not near my phone and when I do get a chance to take a look, I only see the most recent alert so I'm not sure what else has happened. So, I need to then jump into zmNinja (which also works flawlessly byt the way, so thank you) and dig around through each event until I've seen them all (or just verify that that was the only alert. I don't know if there were more as I only see the one notification). It would be a huge time saver to just simply browse through all the notifications I've received and know what and where they were so I could decided if they are worth me going over all the footage or not.

I hope this makes sense and thank you very much again for all your work!

@pliablepixels
Copy link
Member

Congratulations - you actually logged this in the right place. Most people would have logged this in the zmNinja repo. Will read and revert - in the middle of a beta release atm :-)

@eekay35
Copy link
Author

eekay35 commented Feb 25, 2019

Fantastic! I figured it was already in the works or that someone else had made the same request, I just didn't see it here (I didn't figure it belonged in the zmNinja repo?). Anyhow, great! And, thanks again for everything!

@pliablepixels
Copy link
Member

@eekay35 try this:

  • Replace these lines in zmeventnotification.pl with this payload
  • All we are doing is adding a notId field to the android message
  • Make sure you stop your event server and start again to make sure this code is loaded
  • Please see if you now see multiple notifications in the shade

@eekay35
Copy link
Author

eekay35 commented Feb 26, 2019

Great! Trying now. Being as I was still on zmeventnotification.pl version 2.6, I've pulled the 3.1 version you've supplied (It looks like this is safe?) and I've applied the patch and restarted. No errors in the log. Will go and get some notifications shortly and see if there are multiple in the shade.

@eekay35
Copy link
Author

eekay35 commented Feb 26, 2019

So, it appears to be performing the same way:

I see the notification:
20190225-181342

I pull down the notification bar and it display more information about the notification:
20190225_182338

Then, I can pull down on that notification and see the image attached to it:
20190225_182408

However, there is only one notification to view. The previous notifications are still being bumped by the most recent. If there's anything else you'd like me to try, I'll be more than happy to do so. Thanks again!

@pliablepixels
Copy link
Member

pliablepixels commented Feb 26, 2019

I've been playing around and haven't found a simple solution.

The status:

  1. If you don't use pictures, you'll notice the events are stacked inbox style
  2. If you do use pictures, I need to change the style from inbox to picture to show the image. The problem then is that new messages replace old ones.
  3. There is a third option that involves adding a notId to the message payload that changes with each message. That will then show multiple notifications but the problem is they all seem to have individual icons crowding your status bar which is terrible

I've created an issue in the plugin repo to see if there is a simple solution.

(FYI payload stacking/etc parameters are here)

@pliablepixels pliablepixels changed the title "Stacking" Event Notifications. "Stacking" Event Notifications(Android). Feb 26, 2019
@eekay35
Copy link
Author

eekay35 commented Feb 26, 2019

This all makes perfect sense. I normally wouldn't have a problem with with no picture being attached to the notification but a) it's very handy to immediately see what's happening and b) simply clicking on the notification doesn't take me to the event. It just opens zmNinja to whatever page I was previously viewing (usually the "Monitors" page). So, I still need to dig/search for the event to see what was captured.

While I do see option 3 as an undesired side effect of multiple notifications (with pictures), I don't know if I, personally, would say it's terrible. Then again, I usually only get 1-3 notifications before I'm able to check them. So, it wouldn't burden my notification bar too badly. Others may not feel the same way.

I do appreciate you looking into this, though! It would definitely be an awesome addition/feature to have.

@pliablepixels
Copy link
Member

simply clicking on the notification doesn't take me to the event. It just opens zmNinja to whatever page I was previously viewing (usually the "Monitors" page). So, I still need to dig/search for the event to see what was captured.

You can select the tap action. Go to zmninja>settings>event server> onTap navigate to

@eekay35
Copy link
Author

eekay35 commented Feb 27, 2019

Whoa! I swear I tried that when I first set this up and I just could not get that to work. Appears to be working now, though! Thanks for mentioning it or I wouldn't have tried it again.

@stale
Copy link

stale bot commented Mar 23, 2019

This issue has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. Thank you for your contributions.

@stale stale bot added the stale label Mar 23, 2019
@stale stale bot closed this as completed Mar 27, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

2 participants