Skip to content
This repository has been archived by the owner on Jun 19, 2024. It is now read-only.

Feature Request: Transactions by address. #101

Closed
hkey0 opened this issue Feb 7, 2024 · 12 comments
Closed

Feature Request: Transactions by address. #101

hkey0 opened this issue Feb 7, 2024 · 12 comments
Assignees
Labels
enhancement New feature or request

Comments

@hkey0
Copy link

hkey0 commented Feb 7, 2024

Hello, I have a few ideas about improving namadexer.

  • List of transactions of the specified transparent address.
  • List of all validators (with total stake)

It would be great if it had these features.

@hkey0 hkey0 changed the title Feature Request: Transactions of the address. Feature Request: Transactions by address. Feb 7, 2024
@rllola
Copy link
Contributor

rllola commented Feb 7, 2024

Hey @hkey0

Looks like good ideas. We will work on this ASAP.

@rllola
Copy link
Contributor

rllola commented Feb 7, 2024

List of transactions of the specified transparent address.

Unfortunately today we don't have all the decrypted info in a table so researching through addresses will return incomplete answer. However there is a solution proposed by my colleague to store the arbitrary data as JSON and postgres could handle searching in the JSON string. However it could impact negatively the performances.

@hkey0
Copy link
Author

hkey0 commented Feb 7, 2024

List of transactions of the specified transparent address.

Unfortunately today we don't have all the decrypted info in a table so researching through addresses will return incomplete answer. However there is a solution proposed by my colleague to store the arbitrary data as JSON and postgres could handle searching in the JSON string. However it could impact negatively the performances.

Can't we see all transactions of transparent addresses? Why can't we do that?

@rllola
Copy link
Contributor

rllola commented Feb 8, 2024

Can't we see all transactions of transparent addresses? Why can't we do that?

Because the addresses are in the blob of data and we don't know how to look them up in sql. Unless like mentioned we store it in JSON.

We are currently looking at this approach.

@hkey0
Copy link
Author

hkey0 commented Feb 8, 2024

Can't we see all transactions of transparent addresses? Why can't we do that?

Because the addresses are in the blob of data and we don't know how to look them up in sql. Unless like mentioned we store it in JSON.

We are currently looking at this approach.

Is it possible to use the tx search in cometbft?
Querying Transactions Events: https://docs.cometbft.com/v0.37/app-dev/indexing-transactions

@ainhoa-a ainhoa-a added the enhancement New feature or request label Feb 20, 2024
@opsecx
Copy link
Contributor

opsecx commented Feb 26, 2024

Can't we see all transactions of transparent addresses? Why can't we do that?

Because the addresses are in the blob of data and we don't know how to look them up in sql. Unless like mentioned we store it in JSON.

We are currently looking at this approach.

aren't all the transactions already in a separate table? I can see all of them in the indexer currently? (pretor)

@rllola
Copy link
Contributor

rllola commented Feb 29, 2024

I have started to work on this.

@opsecx In the current main branch we don't have the tx_transfer table anymore instead all the data are stored as JSON object in the transactions table. Also tx_transfer transaction might not represent all the transactions associated with an address. So now we can collect from all other kind of transactions.

I will share here the draft PR when it is ready.

@opsecx
Copy link
Contributor

opsecx commented Mar 1, 2024

So all applications built to old format will fail if pulling the revised source tree? that's a lot of extra work on this end

@opsecx
Copy link
Contributor

opsecx commented Mar 1, 2024

I have to say that breaking changes like these are extremely inconvenient

@rllola
Copy link
Contributor

rllola commented Mar 1, 2024

So all applications built to old format will fail if pulling the revised source tree? that's a lot of extra work on this end

No there is no breaking changes on the endpoints. You should be all good.

@opsecx
Copy link
Contributor

opsecx commented Mar 2, 2024

So all applications built to old format will fail if pulling the revised source tree? that's a lot of extra work on this end

No there is no breaking changes on the endpoints. You should be all good.

I'm drawing directly off the db, so I'm assuming the answer to the question is yes

@rllola
Copy link
Contributor

rllola commented Mar 12, 2024

Done with #161

@rllola rllola closed this as completed Mar 12, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
enhancement New feature or request
Projects
None yet
Development

No branches or pull requests

4 participants