Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ZIP 32 Support #52

Open
murisi opened this issue Jul 23, 2024 · 3 comments · May be fixed by #61
Open

ZIP 32 Support #52

murisi opened this issue Jul 23, 2024 · 3 comments · May be fixed by #61

Comments

@murisi
Copy link
Contributor

murisi commented Jul 23, 2024

The Ledger app does not seem to support ZIP 32 paths. This is problematic because the Namada wallet uses these for MASP keys and addresses. For instance attempting to execute app.retrieveKeys(hdpath, NamadaKeys.ProofGenerationKey, false) with hdpath set to m/32'/877'/0' yields the return code 0x6700 (APDU_CODE_WRONG_LENGTH). Would it be possible to add ZIP 32 support (i.e paths and key derivations) to the Ledger Namada app? Or maybe point to documentation of its usage if ZIP 32 support is already there and I'm using the API incorrectly?

@chcmedeiros
Copy link
Collaborator

Hey @murisi we were not supporting Zip32, but we will add the support.

@murisi
Copy link
Contributor Author

murisi commented Jul 24, 2024

Thanks @chcmedeiros . Also, would it be possible for the Ledger app to generate and display extended full viewing keys at the account level of the ZIP 32 hierarchy, and provide it amongst the app's key responses? Doing this would ease integration with namadaw which currently only supports importing extended full viewing keys and payment addresses.

@murisi
Copy link
Contributor Author

murisi commented Aug 30, 2024

Thanks @chcmedeiros . Also, would it be possible for the Ledger app to generate and display extended full viewing keys at the account level of the ZIP 32 hierarchy, and provide it amongst the app's key responses? Doing this would ease integration with namadaw which currently only supports importing extended full viewing keys and payment addresses.

Hi again @chcmedeiros ! Would it be possible to provide support for extended full viewing keys at a minimum? Our CLI and web clients only support extended full viewing keys as inputs (and the MASP library only supports extended spending keys for building transactions). I'm thinking that an approach similar to #61 or a subset of it could be used to achieve this goal...

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants