Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Until now, we had a separate value function for reach-avoid and for reward specifications (for each model type), which was a violation of DRY and more unmaintainable. With the introduction of the
postprocess!
function (called immediately after a value iteration step) in this PR, we can unify the two types of value functions (still separate for each model) and reduce the copies of the value iteration to maintain.postprocess!
does the following:An additional benefit of this approach is that we decouple the specification and the system (again), since it no longer requires that the terminal set for reachability/reach-avoid only has a loop to itself (simplifying the safety checks introduced in #34).