Add query parameters argument to Router.prototype.url method

[nschloe]

koa-router's url method supports name and parameters. In addition to this, I would like to construct a URL with query parameters, e.g.,

/test?q=abc&number=123

Is it possible to use the url method for it yet? Proper escaping would be nice too.

[mastilver]

It's already available using https://github.com/koajs/koa

Check out: https://github.com/koajs/koa/blob/9f80296fc49fa0c03db939e866215f3721fcbbc6/test/request/query.js#L23

router.get('/test', function *(next) {
    var ctx = this;

    console.log(ctx.query.q);
    // => 'abc'
    console.log(ctx.query.number);
    // => 123
});

[nschloe]

Thanks for the reply! Do you think the same would be possible for the url method? Right now, I'm using it in the context of

this.status = 303;
this.redirect(router.url('document', doc.document) + '?revision=' + doc._id);

The latter ?revision=... part is the one that been bugging me.

[mastilver]

It's not handled

What do you think about:

router.url('document', doc.document, {
    query: {
        revision: doc._id
    }
})

I will try to send a PR tonight

[nschloe]

Just what I was looking for.

[wachunei]

Hi. Are there any plans on supporting this?

[jbielick]

@wachunei No plans that I've seen, but a PR could be opened with some work that matches what was discussed here—seems like there would be support for it.

[wachunei]

PR sent, check #396

[jbielick]

published at 7.3.0