fix(picker): picker prompt also need the value prop
#1172
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
|
🎊 PR Preview has been successfully built and deployed to https://zarm-preview-pr-1172.surge.sh
|
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #1172 +/- ##
=======================================
Coverage 90.40% 90.40%
=======================================
Files 220 220
Lines 5125 5127 +2
Branches 1219 1218 -1
=======================================
+ Hits 4633 4635 +2
Misses 482 482
Partials 10 10 ☔ View full report in Codecov by Sentry. |
JeromeLin
reviewed
Aug 19, 2024
| @@ -494,7 +494,7 @@ ReactDOM.render(<Demo />, mountNode); | |||
| Picker 支持指令式调用，提供了 `prompt` 方法 | |||
|
|
|||
| ```tsx | |||
| prompt: (props: Omit<PickerProps, 'visible' | 'visible' | 'children'>) => | |||
There was a problem hiding this comment.
value 属性还是需要的吧，只是这里的文档有错误，应该是 'value' | 'visible' | 'children'
There was a problem hiding this comment.
prompt 如果不支持 value ，已选项没法正确回填
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.