Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Tests are not indicative? #177

Open
2 of 6 tasks
ps-george opened this issue Sep 4, 2019 · 6 comments · Fixed by #192
Open
2 of 6 tasks

Tests are not indicative? #177

ps-george opened this issue Sep 4, 2019 · 6 comments · Fixed by #192
Assignees
Labels
question Further information is requested
Milestone

Comments

@ps-george
Copy link
Collaborator

ps-george commented Sep 4, 2019

In #175, it passes CI but we aren't sure if it works live.

We should be able to gain a certain amount of confidence that a commit works from whether CI passes or not.

@ps-george ps-george added the question Further information is requested label Sep 4, 2019
@ymherklotz
Copy link
Member

CI is working: https://travis-ci.org/ymherklotz/FMark

We just need to add a test that parses a 10000 line markdown file for example, hopefully under 1sec.

@ps-george
Copy link
Collaborator Author

Do we test the bundled .js output?

@ps-george
Copy link
Collaborator Author

ps-george commented Sep 21, 2019

Does CI still work after switching repo? Is it still at /ymherklotz/FMark? @ymherklotz any plan to move it to zestylogic/FMark or is it all good to leave it where it is?

@ymherklotz
Copy link
Member

Just moved it to https://travis-ci.org/Zestylogic/FMark. Going to fix it in the documentation.

@ps-george
Copy link
Collaborator Author

image

What was the reason that we ignored these 4 tests? Time?

Maybe they will be okay to include after #175 is merged and #179 is done?

@ps-george ps-george added this to the Clean Up milestone Sep 22, 2019
@ymherklotz
Copy link
Member

One of them is one of mine, which is a broken property test, don't know about the others.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
question Further information is requested
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants