From 9e818a520dd5a977906384263a85cb1f95b44382 Mon Sep 17 00:00:00 2001 From: Ankita Kinger Date: Tue, 12 Nov 2024 18:17:58 +0530 Subject: [PATCH] chore: Updating the settings icon throughout the product (#37330) MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit ## Description Updating the settings icon throughout the product to use the below icon: https://www.figma.com/design/8L9BXMzNTKboGWlHpdXyYP/Appsmith-IDE?node-id=33-3546&t=qpptzxhkWatrFIn1-4 Fixes [#37248](https://github.com/appsmithorg/appsmith/issues/37248) ## Automation /ok-to-test tags="@tag.Sanity" ### :mag: Cypress test results > [!TIP] > 🟢 🟢 🟢 All cypress tests have passed! 🎉 🎉 🎉 > Workflow run: > Commit: 0e57343a6c2b7543f37e37940f8447be10ccd9e9 > Cypress dashboard. > Tags: `@tag.Sanity` > Spec: >
Tue, 12 Nov 2024 12:12:33 UTC ## Communication Should the DevRel and Marketing teams inform users about this change? - [ ] Yes - [ ] No ## Summary by CodeRabbit - **New Features** - Updated icons for various settings-related components from "settings-2-line" to "settings-v3" to enhance visual representation. - **Bug Fixes** - Improved handling of frame ancestor settings in the AdminSettings configuration, ensuring better management of stored values. - **Documentation** - No changes to the documentation were made in this release. - **Chores** - Updated multiple components to reflect the new icon, maintaining overall functionality without introducing new logic. --- .../__assets__/icons/ads/settings-v3-icon.svg | 24 +++---------------- .../src/migrate/helpers/widget-configs.json | 4 ++-- src/IDE/Components/ToolbarSettingsPopover.tsx | 2 +- src/ce/pages/AdminSettings/config/general.tsx | 2 +- src/ce/pages/Applications/WorkspaceMenu.tsx | 2 +- .../propertyControls/DraggableListCard.tsx | 2 +- .../propertyPaneConfig/contentConfig.ts | 2 +- .../AppSettingsPane/AppSettings/index.tsx | 2 +- .../Editor/gitSync/QuickGitActions/index.tsx | 2 +- .../GitChangesList/StaticChange.tsx | 2 +- .../common/SearchBar/HomepageHeaderAction.tsx | 2 +- .../widget/propertyConfig/contentConfig.ts | 2 +- .../propertyConfig/PanelConfig/Basic.ts | 2 +- 13 files changed, 16 insertions(+), 34 deletions(-) diff --git a/packages/design-system/ads/src/__assets__/icons/ads/settings-v3-icon.svg b/packages/design-system/ads/src/__assets__/icons/ads/settings-v3-icon.svg index df11c445c5b7..0fdaa570ff59 100644 --- a/packages/design-system/ads/src/__assets__/icons/ads/settings-v3-icon.svg +++ b/packages/design-system/ads/src/__assets__/icons/ads/settings-v3-icon.svg @@ -1,21 +1,3 @@ - - - - - - - + + + \ No newline at end of file diff --git a/packages/dsl/src/migrate/helpers/widget-configs.json b/packages/dsl/src/migrate/helpers/widget-configs.json index 2aefa6fae959..ddd827e9bfb2 100644 --- a/packages/dsl/src/migrate/helpers/widget-configs.json +++ b/packages/dsl/src/migrate/helpers/widget-configs.json @@ -7311,7 +7311,7 @@ "controlType": "OPEN_CONFIG_PANEL", "buttonConfig": { "label": "Configure", - "icon": "settings-2-line" + "icon": "settings-v3" }, "label": "Configure menu items", "isBindProperty": false, @@ -47874,7 +47874,7 @@ "controlType": "OPEN_CONFIG_PANEL", "buttonConfig": { "label": "Configure", - "icon": "settings-2-line" + "icon": "settings-v3" }, "label": "Configure menu items", "isBindProperty": false, diff --git a/src/IDE/Components/ToolbarSettingsPopover.tsx b/src/IDE/Components/ToolbarSettingsPopover.tsx index 9777ba6093fc..3a2e8d266685 100644 --- a/src/IDE/Components/ToolbarSettingsPopover.tsx +++ b/src/IDE/Components/ToolbarSettingsPopover.tsx @@ -45,7 +45,7 @@ export const ToolbarSettingsPopover = (props: Props) => { - + Settings diff --git a/src/components/propertyControls/DraggableListCard.tsx b/src/components/propertyControls/DraggableListCard.tsx index 2cbe8e45b500..04b368dee55a 100644 --- a/src/components/propertyControls/DraggableListCard.tsx +++ b/src/components/propertyControls/DraggableListCard.tsx @@ -205,7 +205,7 @@ export function DraggableListCard(props: RenderComponentProps) { }} onFocus={(e) => e.stopPropagation()} size="sm" - startIcon="settings-2-line" + startIcon="settings-v3" /> )} {showDelete && ( diff --git a/src/modules/ui-builder/ui/wds/WDSMenuButtonWidget/config/propertyPaneConfig/contentConfig.ts b/src/modules/ui-builder/ui/wds/WDSMenuButtonWidget/config/propertyPaneConfig/contentConfig.ts index 4af8b7bb0c5d..52525d150834 100644 --- a/src/modules/ui-builder/ui/wds/WDSMenuButtonWidget/config/propertyPaneConfig/contentConfig.ts +++ b/src/modules/ui-builder/ui/wds/WDSMenuButtonWidget/config/propertyPaneConfig/contentConfig.ts @@ -88,7 +88,7 @@ export const propertyPaneContentConfig = [ controlType: "OPEN_CONFIG_PANEL", buttonConfig: { label: "Configure", - icon: "settings-2-line", + icon: "settings-v3", }, label: "Configure menu items", isBindProperty: false, diff --git a/src/pages/Editor/AppSettingsPane/AppSettings/index.tsx b/src/pages/Editor/AppSettingsPane/AppSettings/index.tsx index f9ab07a72fd3..4b36172798b2 100644 --- a/src/pages/Editor/AppSettingsPane/AppSettings/index.tsx +++ b/src/pages/Editor/AppSettingsPane/AppSettings/index.tsx @@ -126,7 +126,7 @@ function AppSettings() { const SectionHeadersConfig: SectionHeaderProps[] = [ { id: "t--general-settings-header", - icon: "settings-2-line", + icon: "settings-v3", isSelected: selectedTab.type === AppSettingsTabs.General, name: createMessage(GENERAL_SETTINGS_SECTION_HEADER), onClick: () => { diff --git a/src/pages/Editor/gitSync/QuickGitActions/index.tsx b/src/pages/Editor/gitSync/QuickGitActions/index.tsx index e1285d1011f2..0cfcd08976b5 100644 --- a/src/pages/Editor/gitSync/QuickGitActions/index.tsx +++ b/src/pages/Editor/gitSync/QuickGitActions/index.tsx @@ -215,7 +215,7 @@ const getQuickActionButtons = ({ }, { className: "t--bottom-git-settings", - icon: "settings-2-line", + icon: "settings-v3", onClick: settings, tooltipText: createMessage(GIT_SETTINGS), }, diff --git a/src/pages/Editor/gitSync/components/GitChangesList/StaticChange.tsx b/src/pages/Editor/gitSync/components/GitChangesList/StaticChange.tsx index 118e5cf7b62b..a0dbc1228e79 100644 --- a/src/pages/Editor/gitSync/components/GitChangesList/StaticChange.tsx +++ b/src/pages/Editor/gitSync/components/GitChangesList/StaticChange.tsx @@ -49,7 +49,7 @@ const allStaticChangeDefs: Record< [StaticChangeKind.SETTINGS]: (status: GitStatusData) => ({ condition: status.modified.includes("application.json"), message: "Application settings modified", - iconName: "settings-2-line", + iconName: "settings-v3", }), [StaticChangeKind.THEME]: (status: GitStatusData) => ({ condition: status.modified.includes("theme.json"), diff --git a/src/pages/common/SearchBar/HomepageHeaderAction.tsx b/src/pages/common/SearchBar/HomepageHeaderAction.tsx index 5776435651f5..8d259e9d7ae6 100644 --- a/src/pages/common/SearchBar/HomepageHeaderAction.tsx +++ b/src/pages/common/SearchBar/HomepageHeaderAction.tsx @@ -92,7 +92,7 @@ const HomepageHeaderAction = ({ }); }} size="md" - startIcon="settings-control" + startIcon="settings-v3" /> )} diff --git a/src/widgets/MenuButtonWidget/widget/propertyConfig/contentConfig.ts b/src/widgets/MenuButtonWidget/widget/propertyConfig/contentConfig.ts index b36704b62b3e..78121c0f731a 100644 --- a/src/widgets/MenuButtonWidget/widget/propertyConfig/contentConfig.ts +++ b/src/widgets/MenuButtonWidget/widget/propertyConfig/contentConfig.ts @@ -89,7 +89,7 @@ export default [ controlType: "OPEN_CONFIG_PANEL", buttonConfig: { label: "Configure", - icon: "settings-2-line", + icon: "settings-v3", }, label: "Configure menu items", isBindProperty: false, diff --git a/src/widgets/TableWidgetV2/widget/propertyConfig/PanelConfig/Basic.ts b/src/widgets/TableWidgetV2/widget/propertyConfig/PanelConfig/Basic.ts index 837acc498f4d..ba370ac0ff61 100644 --- a/src/widgets/TableWidgetV2/widget/propertyConfig/PanelConfig/Basic.ts +++ b/src/widgets/TableWidgetV2/widget/propertyConfig/PanelConfig/Basic.ts @@ -181,7 +181,7 @@ export default { controlType: "OPEN_CONFIG_PANEL", buttonConfig: { label: "Configure", - icon: "settings-2-line", + icon: "settings-v3", }, label: "Configure menu items", isBindProperty: false,