You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
{{ message }}
This repository has been archived by the owner on Sep 25, 2023. It is now read-only.
Description
Currently, every skin has their own set of resources. This makes management easy, but has a significant impact on the client, as they might have to download identical files multiple times.
For example, all poolball skins use the same normal map. It would be pointless to download it separately for every variation.
Minimum Acceptance Criteria
Skins resources can be shared by defining so in the meta.json file.
A default vertex shader should be present for shader based skins, as it is generally identical. A custom one should still be supported.
The text was updated successfully, but these errors were encountered:
I don't think not having shared skin resources is currently an issue. Normal maps are generally unique to the marble skin, with the exception to the poolball skins. Adding to that, the normal maps of the poolball skins are visually so insignificant that I think the better option is to simply remove these normal maps entirely.
The default vertex shader could be a useful feature, though. We can opt to define a hard-coded vertex shader whenever a skin's vertex.glsl doesn't exist.
Sign up for freeto subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Description
Currently, every skin has their own set of resources. This makes management easy, but has a significant impact on the client, as they might have to download identical files multiple times.
For example, all poolball skins use the same normal map. It would be pointless to download it separately for every variation.
Minimum Acceptance Criteria
meta.json
file.The text was updated successfully, but these errors were encountered: