Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

handle ipp/ipps explicitly #20

Open
wants to merge 1 commit into
base: master
Choose a base branch
from
Open

Conversation

jswolf19
Copy link

@jswolf19 jswolf19 commented Dec 11, 2023

closes #19

The http request scheme is currently hard coded, so using https or ipps is not currently supported.
ipp requests do not currently default to port 631.

If ipp or ipps is the scheme and a port is not provided, the port should default to 663 (and not 80/443).

This would be a breaking change for usages where

  • the uri scheme is ipp, but a port is not provided and a connection on port 80 is desired
  • ipps/https are specified but an insecure connection on port 80(when port is unspecified) is desired

This should solve any issues addresed by #16 but won't break usages that currently supply an ipp uri scheme.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

uri scheme support
1 participant