Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Rename endpoint.php to index.php #9

Open
skpy opened this issue May 13, 2018 · 3 comments
Open

Rename endpoint.php to index.php #9

skpy opened this issue May 13, 2018 · 3 comments
Milestone

Comments

@skpy
Copy link

skpy commented May 13, 2018

It would be nice to be able to clone this repo into a new directory and have it accessible as the index of that directory. Then the <head> of the sites with which I use this could simply reference <link rel="token_endpoint" href="https://example.com/token/">, rather than <link rel="token_endpoint" href="https://example.com/token/endpoint.php">.

@Zegnat
Copy link
Owner

Zegnat commented May 13, 2018

I am divided on this. As I mention in step 6, I have actually put endpoint.php in the same folder as Selfauth. This would not work with index.php.

Not sure what the best default case is.

@skpy
Copy link
Author

skpy commented May 14, 2018

I considered this before making the suggestion. If you're manually copying the file into a different directory, then renaming the file in the process of copying it does not add much burden. Unless the directory into which you copy it is not version controlled, AND that directory has an index.php, AND you accidentally forget to change the name, then there's not much risk here. If a user copies this index.php over a different index.php, well ... I hope they have backups!

I'd love to have this live in the same directory as selfauth, but I do not want to manually copy files around. If this file were migrated to the selfauth repo (and, perhaps, named token.php), it would make this all a bit easier (for me).

Feel free to close this issue if you wish. It's not a big deal to me either way.

@Zegnat
Copy link
Owner

Zegnat commented May 14, 2018

After a good night of thinking, I might be coming around to this.

I was looking at possibly streamlining the installation through composer (composer create-project), and that too always wants to install into an empty folder. Much like git.

If all the tooling people are likely to use are creating new folders, I may as well rename it index.

@Zegnat Zegnat changed the title Rename endpoint.php to index.php? Rename endpoint.php to index.php May 22, 2018
@Zegnat Zegnat added this to the v3 milestone May 22, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants