Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Tests populate the state with Sprout trees without cached roots #8739

Closed
upbqdn opened this issue Aug 3, 2024 · 0 comments · Fixed by #8741
Closed

Tests populate the state with Sprout trees without cached roots #8739

upbqdn opened this issue Aug 3, 2024 · 0 comments · Fixed by #8741
Assignees
@upbqdn
Labels
A-state Area: State / database changes C-bug Category: This is a bug C-testing Category: These are tests

Comments

@upbqdn
Copy link
Member

upbqdn commented Aug 3, 2024 •
edited
Loading

Fix https://github.com/ZcashFoundation/zebra/actions/runs/10206510523/job/28239564875?pr=8729#step:12:4658.

Zebra's database expects all stored Sprout trees to have their roots cached. We were storing the trees without cached roots in tests, but the bug didn't show up until we bumped the major database format version in #8729 due to #8740.
@upbqdn upbqdn added C-bug Category: This is a bug C-testing Category: These are tests A-state Area: State / database changes labels Aug 3, 2024
@upbqdn upbqdn self-assigned this Aug 3, 2024
@github-project-automation github-project-automation bot moved this to New in Zebra Aug 3, 2024
This was referenced Aug 3, 2024
Open
Merged
@mergify mergify bot closed this as completed in #8741 Aug 3, 2024
@github-project-automation github-project-automation bot moved this from New to Done in Zebra Aug 3, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@upbqdn upbqdn

Labels
A-state Area: State / database changes C-bug Category: This is a bug C-testing Category: These are tests
Projects
Zebra
Status: Done
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

fix: Cache Sprout tree roots in tests ZcashFoundation/zebra
1 participant
@upbqdn