Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Compare config file and database after restart, act accordingly #8101

Closed
1 task
Tracked by #7728
oxarbitrage opened this issue Dec 13, 2023 · 4 comments
Closed
1 task
Tracked by #7728

Compare config file and database after restart, act accordingly #8101

oxarbitrage opened this issue Dec 13, 2023 · 4 comments
Labels
A-blockchain-scanner Area: Blockchain scanner of shielded transactions

Comments

@oxarbitrage
Copy link
Contributor

Currently we can have differences between the config and the database in regards to keys. This was part of #8022 but it is moved to its own ticket.

  • After the new keys are inserted, compare the keys in the database and in the config:
    • If keys are deleted from the config, don't start any scan for them, keep results if any.
    • If key is in both places, check the last scanned height from the database and scan up to tip from that height only.
    • (It is impossible for keys to only be in the config, because we waited for their birthdays to be inserted.)

Move was done because deleting things from the database can be complicated.

@mpguerra mpguerra added this to Zebra Dec 13, 2023
@github-project-automation github-project-automation bot moved this to 🆕 New in Zebra Dec 13, 2023
@mpguerra
Copy link
Contributor

Just confirming that this issue is out of scope for the MVP?

@oxarbitrage
Copy link
Contributor Author

Just confirming that this issue is out of scope for the MVP?

Correct.

@teor2345 teor2345 changed the title Compare config file and database after restart, act accordingly. Compare config file and database after restart, act accordingly Jan 8, 2024
@mpguerra mpguerra moved this from New to Product Backlog in Zebra Jan 16, 2024
@mpguerra mpguerra added the A-blockchain-scanner Area: Blockchain scanner of shielded transactions label Mar 6, 2024
@mpguerra
Copy link
Contributor

mpguerra commented Jul 5, 2024

@oxarbitrage do we still need to do this now that we're separating the scanner out?

@mpguerra
Copy link
Contributor

We won't be doing any more work on the scanner

@mpguerra mpguerra closed this as not planned Won't fix, can't repro, duplicate, stale Oct 18, 2024
@github-project-automation github-project-automation bot moved this from Product Backlog to Done in Zebra Oct 18, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
A-blockchain-scanner Area: Blockchain scanner of shielded transactions
Projects
Status: Done
Development

No branches or pull requests

2 participants