Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove the zebrad download command #7811

Closed
teor2345 opened this issue Oct 24, 2023 · 0 comments · Fixed by #7819
Closed

Remove the zebrad download command #7811

teor2345 opened this issue Oct 24, 2023 · 0 comments · Fixed by #7819
Assignees
Labels
A-consensus Area: Consensus rule updates C-removal Category: Features that have been removed

Comments

@teor2345
Copy link
Contributor

teor2345 commented Oct 24, 2023

Motivation

This is a cleanup after #7613, but it involves removing a zebrad command-line command.

Remove the zebrad download command, and everything that depends on it.
This includes zcash-params/Dockerfile, and anywhere it is used in workflows and the main Dockerfile.

Complex Code or Requirements

This is a breaking change for anyone that manually runs the zebrad download command. But we can't predict how it's used, and it doesn't create files any more, so it's best to just remove it, rather than silently making it not work.

Testing

CI should pass with the Dockerfiles and commands removed.

@teor2345 teor2345 added A-consensus Area: Consensus rule updates S-needs-triage Status: A bug report needs triage P-Medium ⚡ C-removal Category: Features that have been removed labels Oct 24, 2023
@mpguerra mpguerra added this to Zebra Oct 24, 2023
@github-project-automation github-project-automation bot moved this to 🆕 New in Zebra Oct 24, 2023
@teor2345 teor2345 self-assigned this Oct 24, 2023
@mergify mergify bot closed this as completed in #7819 Oct 25, 2023
@github-project-automation github-project-automation bot moved this from 🆕 New to ✅ Done in Zebra Oct 25, 2023
@mpguerra mpguerra removed the S-needs-triage Status: A bug report needs triage label Oct 26, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
A-consensus Area: Consensus rule updates C-removal Category: Features that have been removed
Projects
Status: Done
2 participants