Fix "the resource was not found" instance errors in CI

[teor2345]

Motivation

I'm seeing errors like this in CI:

• The resource 'projects/zealous-zebra/zones/us-central1-a/instances/update-to-tip-5360-merge-818a593' was not found

https://github.com/ZcashFoundation/zebra/actions/runs/3203311358/jobs/5239744583#step:6:101

Command Reference

https://cloud.google.com/sdk/gcloud/reference/topic/filters

Designs

I'm not sure what is causing these bugs, we only delete instances after 3 days:

zebra/.github/workflows/delete-gcp-resources.yml

Line 56 in ee0edef

INSTANCES=$(gcloud compute instances list --sort-by=creationTimestamp --filter="name~-[0-9a-f]{7,}$ AND creationTimestamp < $DELETE_BEFORE_DATE" --format='value(NAME,ZONE)' | \

And after the job fails:

zebra/.github/workflows/deploy-gcp-tests.yml

Line 1329 in ee0edef

INSTANCE=$(gcloud compute instances list --filter=${{ inputs.test_id }}-${{ env.GITHUB_REF_SLUG_URL }}-${{ env.GITHUB_SHA_SHORT }} --format='value(NAME)')

Maybe we got a failed instance or outdated instance delete script wrong somewhere?
We could try using name={{key}} for failed job deletes, but it might not be causing this problem.

Let's check the Google Cloud logs to work out what is deleting these instances.

[teor2345]

Failed in PR #5541, halfway through the test run:
https://github.com/ZcashFoundation/zebra/actions/runs/3390759314/jobs/5636067584#step:6:106

[mpguerra]

Hey team! Please add your planning poker estimate with Zenhub @arya2 @dconnolly @gustavovalverde @oxarbitrage @teor2345

[teor2345]

@gustavovalverde did this get fixed by the recent changes?

[teor2345]

We haven't seen this bug for a while.

[teor2345]

I haven't seen these in ages?