Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add tests for Inbound::Request::PushTransaction and Inbound::Request::AdvertiseTransactionIds #2745

Closed
oxarbitrage opened this issue Sep 8, 2021 · 2 comments · Fixed by #2769
Closed

Add tests for Inbound::Request::PushTransaction and Inbound::Request::AdvertiseTransactionIds #2745

oxarbitrage opened this issue Sep 8, 2021 · 2 comments · Fixed by #2769
Assignees
@oxarbitrage
Milestone
2021 Sprint 18

Comments

@oxarbitrage
Copy link
Contributor

In #2727 we added code to handle this 2 mempool requests but we didn't added tests into https://github.com/ZcashFoundation/zebra/blob/main/zebrad/src/components/inbound/tests.rs because we have another in flight PR (#2741) which makes some big changes to this part of the code so we don't want to refactor them after it.

This tests can be added as part of #2741 or in a separated PR.
@mpguerra mpguerra added this to the 2021 Sprint 18 milestone Sep 9, 2021
@oxarbitrage
Copy link
Contributor Author

Will do this after #2741 is merged.

@oxarbitrage oxarbitrage added the S-blocked Status: Blocked on other tasks label Sep 11, 2021
@oxarbitrage oxarbitrage self-assigned this Sep 11, 2021
@mpguerra
Copy link
Contributor

Hey team! Please add your planning poker estimate with ZenHub @conradoplg @dconnolly @jvff @oxarbitrage @upbqdn

@oxarbitrage oxarbitrage removed the S-blocked Status: Blocked on other tasks label Sep 14, 2021
@oxarbitrage oxarbitrage mentioned this issue Sep 16, 2021
Merged
@mpguerra mpguerra linked a pull request Sep 17, 2021 that will close this issue
Add missing tests for mempool inbound requests #2769
Merged
@jvff jvff mentioned this issue Sep 22, 2021
Merged
3 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@oxarbitrage oxarbitrage

Labels
None yet
Projects
None yet
Milestone
2021 Sprint 18
Development

Successfully merging a pull request may close this issue.

Add missing tests for mempool inbound requests oxarbitrage/zebra
2 participants
@mpguerra @oxarbitrage