Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Round-trip and benchmark large transparent, sprout, sapling, and orchard blocks #2030

Closed
3 tasks
teor2345 opened this issue Apr 18, 2021 · 1 comment
Closed
3 tasks
Labels
A-rust Area: Updates to Rust code C-enhancement Category: This is an improvement

Comments

@teor2345
Copy link
Contributor

teor2345 commented Apr 18, 2021

Is your feature request related to a problem? Please describe.

Zebra's existing unit tests do round-trip parsing tests for:

  • a large block with a single large transparent transaction with many inputs
  • a large block with many small transparent transactions

In #2018, we add benchmarks for these large blocks.

In #1979, we add the equivalent orchard tests.

That just leaves Sapling, Sprout, and many large outputs.

Describe the solution you'd like

Write a round-trip unit test and serialization benchmarks for:

  • Transparent
    • a large block with a single large transparent transaction with many outputs
    • a large block with many small transparent transactions
  • Sapling
    • a large block with a single large transparent transaction with many inputs
    • a large block with a single large transparent transaction with many outputs
    • a large block with many small transparent transactions
  • Sprout
    • a large block with a single large transparent transaction with many joinsplits
    • a large block with many small transparent transactions

Describe alternatives you've considered

This is a low-priority change that increases test and benchmark coverage.

@teor2345 teor2345 added A-rust Area: Updates to Rust code C-enhancement Category: This is an improvement S-needs-triage Status: A bug report needs triage P-Low labels Apr 18, 2021
@teor2345 teor2345 changed the title Round-trip and benchmark large sprout and sapling blocks Round-trip and benchmark large sprout, sapling, and outputs blocks Apr 18, 2021
@mpguerra mpguerra removed the S-needs-triage Status: A bug report needs triage label Apr 21, 2021
@teor2345 teor2345 changed the title Round-trip and benchmark large sprout, sapling, and outputs blocks Round-trip and benchmark large transparent, sprout, sapling, and orchard blocks Aug 9, 2021
@teor2345
Copy link
Contributor Author

teor2345 commented Mar 1, 2022

This is a useful idea, but we don't need it any time soon.

@teor2345 teor2345 closed this as completed Mar 1, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
A-rust Area: Updates to Rust code C-enhancement Category: This is an improvement
Projects
None yet
Development

No branches or pull requests

2 participants