Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Upgrade to vergen 5 #1741

Closed
3 of 4 tasks
teor2345 opened this issue Feb 15, 2021 · 0 comments · Fixed by #2029
Closed
3 of 4 tasks

Upgrade to vergen 5 #1741

teor2345 opened this issue Feb 15, 2021 · 0 comments · Fixed by #2029
Labels
A-dependencies Area: Dependency file updates A-rust Area: Updates to Rust code C-cleanup Category: This is a cleanup C-enhancement Category: This is an improvement E-help-wanted Call for participation: Help is requested to fix this issue.

Comments

@teor2345
Copy link
Contributor

teor2345 commented Feb 15, 2021 •
edited
Loading

Is your feature request related to a problem? Please describe.

vergen 4 and 5 are breaking changes with a bunch of fixes, features, and removals.

Describe the solution you'd like

  • update to the new API
    • vergen rather than gen
    • Config rather than flags
  • update to the new env var names
  • replace our custom build script with a simple call to vergen (vergen now supports workspaces using libgit2, so we don't need that code any more)
  • update the other vergen tickets with the new env var names

Describe alternatives you've considered

Do nothing, we have to maintain our own rerun-if-changed code.
@teor2345 teor2345 added A-dependencies Area: Dependency file updates A-rust Area: Updates to Rust code C-enhancement Category: This is an improvement C-cleanup Category: This is a cleanup S-needs-triage Status: A bug report needs triage P-Medium labels Feb 15, 2021
This was referenced Feb 15, 2021
Closed
Closed
@mpguerra mpguerra removed the S-needs-triage Status: A bug report needs triage label Feb 22, 2021
This was referenced Feb 24, 2021
Closed
Closed
@teor2345 teor2345 changed the title Upgrade to vergen 4 Upgrade to vergen 5 Mar 22, 2021
@mpguerra mpguerra added the E-help-wanted Call for participation: Help is requested to fix this issue. label Mar 22, 2021
@fanatid fanatid mentioned this issue Apr 18, 2021
Merged
@teor2345 teor2345 mentioned this issue Apr 20, 2021
Merged
2 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
A-dependencies Area: Dependency file updates A-rust Area: Updates to Rust code C-cleanup Category: This is a cleanup C-enhancement Category: This is an improvement E-help-wanted Call for participation: Help is requested to fix this issue.
Projects
None yet
Milestone
No milestone
2 participants
@mpguerra @teor2345