Skip to content
This repository has been archived by the owner on Nov 10, 2024. It is now read-only.

Visibility set to 'Microsoft' seems to be ignored #70

Closed
flcdrg opened this issue Mar 11, 2023 · 9 comments · Fixed by #71
Closed

Visibility set to 'Microsoft' seems to be ignored #70

flcdrg opened this issue Mar 11, 2023 · 9 comments · Fixed by #71
Assignees
Labels
bug Something isn't working

Comments

@flcdrg
Copy link

flcdrg commented Mar 11, 2023

Setting Visibility to Microsoft is being ignored. I can see the UI showing the list, but it doesn't select Microsoft and leaves it as 'Everyone'

@ZanattaMichael ZanattaMichael added more info needed bug Something isn't working labels Mar 11, 2023
@flcdrg
Copy link
Author

flcdrg commented Mar 13, 2023

SelMVP\1.0.5\Module.psm1

I'll see if I can repro the original problem.

This is possibly related - this code block actually errors:

MVPActivity "Twitter" {
    Area "Technical Social Media (Twitter, Facebook, LinkedIn...)"
    Visibility 'Microsoft'
    ContributionArea ".NET"
    Value "Date" "13/03/2023"
    Value "Title" "Twitter"
    Value "URL" "https://twitter.com/DavidRGardiner"
    Value "Description" "Personal Twitter account"
    Value "Number of Talks" 1
    Value "Number of Followers" 1
}
New-MVPActivity : Exception calling "Invoke" with "0" argument(s): "Exception calling "Click" with "0" argument(s):
"Element <li class="Item"> could not be scrolled into view""
At C:\Program Files\WindowsPowerShell\Modules\SelMVP\1.0.5\Module.psm1:2292 char:9

(I am in Australia, but yes the date format is fine - it gets converted to what the UI is happy with)

In this case, if I remove the Visibility line altogether, it submits it successfully.

@flcdrg
Copy link
Author

flcdrg commented Mar 13, 2023

This one reproduces the original problem for me though:

MVPActivity "Test" {
    Area "Sample Code/Projects/Tools"
    Visibility 'Microsoft'
    ContributionArea "Visual Studio Extensibility"
    Value "Date" "13/03/2023"
    Value "Title" "Test"
    Value "URL" "https://marketplace.visualstudio.com"
    Value "Description" "Example"
    Value "Number of Samples" 1
    Value "Number of Downloads" 1
}

The activity is added, but visibility is set to 'Everyone'

@ZanattaMichael
Copy link
Owner

ZanattaMichael commented Mar 13, 2023

No worries. I'm AUS based as well. :-p Out of curiosity what driver/browser are you using?

@flcdrg
Copy link
Author

flcdrg commented Mar 13, 2023

Firefox and geckodriver-v0.32.2-win64

@ZanattaMichael
Copy link
Owner

Thanks for that. I'm investigating now.

@ZanattaMichael
Copy link
Owner

ZanattaMichael commented Mar 13, 2023

I've gotten to the bottom of the issue. The JavaScript isn't catching up to the click event, causing the event to fail. I've refactored the cmdlet and wrapped the logic within looping try/catch (ttry). I need to do some more testing, however I will release a new version tomorrow.

@ZanattaMichael
Copy link
Owner

ZanattaMichael commented Mar 14, 2023

New version is out. Please confirm the issue has been fixed on your end.

https://www.powershellgallery.com/packages/SelMVP/1.0.6

@flcdrg
Copy link
Author

flcdrg commented Mar 14, 2023

Thanks. I've done most of my activities, but if I think of any more I'll try it out.

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
bug Something isn't working
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants