Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

resample Is Unstable #38

Open
dmbaker opened this issue Mar 10, 2021 · 0 comments
Open

resample Is Unstable #38

dmbaker opened this issue Mar 10, 2021 · 0 comments

Comments

@dmbaker
Copy link

dmbaker commented Mar 10, 2021

You are doing the calculations by calculating the center of a the "Sphere." In reality, this is a 2D problem, but in either case you are calculating a radius. When doing robust circle (sphere) calculations, one should explicitly avoid using the radius because in straight hole conditions (parallel vectors) the radius goes to infinity.

You don't need to move the arcs relative to the center (so you don't need to calculate the radius, see above). Just move each survey / arc segment start point to the origin, then do the interpolation.

Also, to calculate omega, just use the tangents you have calculated for each survey station, using the angle method. This way you avoid the straight hole condition issue because you already trap for 0 omega in your SLERP method.

Also, the arc is not undefined when omega is zero. The arc has just degenerated into a line. A line is an arc with an infinite radius.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant