fix(hal): Inherit from Stream instead of HardwareSerial across all supported targets #44
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
1 task
ZZ-Cat
added
Bug Fix 👋💥🐞
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Overview
Fixes #42.
This is a case of that one line of code causing such a big problem.
I honestly thought this was going to take a lot longer to fix. But, nope. All it was, was simply one line of code in my Hardware Abstraction Layer.
Anyway... this Pull Request refactors the
DevBoardsclass to inherit from Arduino'sStreamclass instead of theHardwareSerialclass.This, in future may also help reduce some of the restrictions around hardware compatibility, and reduce the need for me to add in niche code in the Hardware Abstraction Layer that is bespoke to a specific board.
You can now compile CRSF for Arduino for your Arduino Zero and/or any of your Arduino MKR series of development boards with impunity.
Additional
Please note that the version date has changed.
This is the old version date:
This is the new version date for the upcoming Version 0.5.0:
When Version 0.5.0 is released, I highly recommend you update your source code of CRSF for Arduino to this version, as it will bring in critical fixes, plus new hardware targets.