chore(library): Clean up deprecated CI and fix defects #116
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ZZ-Cat
added
CI/CD 🚧
29 tasks
…efect Detector This commences the static code analysis indefinitely
|
Excellent! My Defect Detector has failed, which means my Defect Detector has picked up one (or more) defects in CRSF for Arduino's code-base. |
The Defect Detector needs to be isolated for the sake of fixing any defects it finds.
…d in constructor `serialReceiverLayer::CRSF::CRSF()`
…constructor `serialReceiverLayer::CRSF::CRSF()`
…n constructor `serialReceiverLayer::CRSF::CRSF()`
A copy constructor is `RECOMMENDED`, granted this constructor uses dynamic memory allocation.
This is `RECOMMENDED`, granted it uses dynamic memory allocation.
|
Right. That leaves Once I have the medium defects done, I will go the extra mile and fix up all the low ones, just 'cause I can (and it's driving the perfectionist in me batshit that CRSF for Arduino has any defects at all, and the inner perfectionist won't be happy until the code-base is completely defect free...) |
… This is recommended, granted it uses dynamic memory allocation.
…s is recommended, granted it uses dynamic memory allocation.
…zed in the constructor.
…tialized in the constructor.
…r. This is recommended, granted it uses dynamic memory allocation.
…his is recommended, granted it uses dynamic memory allocation.
C-style casts are unsafe because it does not provide any type safety; sacrificing robustness for 🤏 _that_ much more in performance.
|
Awesome! No defects. =^/,..,^= I will merge this Pull Request once the build check passes. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Overview
This is what I wanted to do with the previous branch, but I let feature creep get the better of me.
Anyway, in this Pull Request, I am removing the deprecated CI files (and their broken badges), and I am fixing any defects that are called out by my Defect Detector.