This repository has been archived by the owner on Jul 3, 2020. It is now read-only.
Check if a permission exist before adding it #113
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
badly ping @arekkas |
|
I'd merge this as a hotfix because permissions are (completely) borken when using doctrine but it doesn't solve the overall problem, as shown in #112 |
bakura10
added a commit
that referenced
this pull request
Dec 9, 2013
Check if a permission exist before adding it
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
ping @BrunoSpy @Arakkas
Does this seem logical to you? My idea of separating role loading and permission loading may have not been the best, I can see a lot of useless traversal and object creation here (each "hasPermission" creates a RecursiveIteratorIterator and do an iteration). But for advanced cases I think it makes sense to load them separately.