-
Notifications
You must be signed in to change notification settings - Fork 56
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
TagBuilder is really slow in controlled mode. #171
Comments
I'm not sure if I understand this correctly but in controlled mode, you shouldn't be able to type something. |
Yes, you should. The only difference would be that the state (value) of the component would be controlled by its parent. Then, after I type something, a All other components behave normally when using in controlled mode. But this one lags a lot when typing anything and changing the state. |
I am unable to reproduce laggy behaviour of TagBuilder described in the issue. Code used in0 KitchenSink: const { TagBuilder, Button } = require('precise-ui'); const MyTagBuilder = () => { const [input, setInput] = React.useState(''); const onInputChange = ({ value }) => { const addValue = (input) => { const deleteValue = ({ value }) => {
} Perhaps the issue has been fixed in the progress already? |
Bug Report
Prerequisites
For more information, see the
CONTRIBUTING
guide.Versions
Version 0.8.1
Description
Using TagBuilder in controlled mode, makes it really slow to react to user typing.
Steps to Reproduce
Expected behavior:
It would show the input a soon as I type.
Actual behavior:
It slugs to show the char I just pressed.
Environment details:
Tested on macOS Mojave 10.14.6
And Chrome Version 76.0.3809.132
The text was updated successfully, but these errors were encountered: