Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Question about PP-score in case of single traversal #8

Open
baurst opened this issue Jan 26, 2024 · 3 comments
Open

Question about PP-score in case of single traversal #8

baurst opened this issue Jan 26, 2024 · 3 comments

Comments

@baurst
Copy link

baurst commented Jan 26, 2024

Hi,

thank you for your great work, and thank you for publishing the code! I have a question regarding your baseline MODEST-PP (R0), which you mention in your paper (the one that does not require multiple traversals).

In the paper you write: "The seed labels are constructed by the exact same process as described in section 3, except we replace the edge weights in Equation 4 by spatial proximity: [...] and do not perform any PP-score-based filtering on the clusters generated by DBSCAN"

Does that mean, that PP score is not used at all in this case? Because if we only have a single traversal, I believe we will divide by zero in formula (3) (log(1) = 0).

This leads me to believe, that it is not used at all (and the fact that it is not used here, when affinity_type == '3d_l2_distance' )

Does this mean that for MODEST-PP, you are basically doing DBSCAN for each point cloud individually, but the edge weights are just the nearest neighbor distances?

Thank you very much for your help!

@YurongYou
Copy link
Owner

Hi Stefan,

Thanks for your interest! I think you understanding is correct. As stated in the paper, for MODEST-PP, we are not using PP at all in the whole process. When doing the clustering in this case, the edge weights are just the nearest neighbor distances.

@baurst
Copy link
Author

baurst commented Jan 28, 2024

That makes sense, thank you very much for the quick response! So for the self improvement you just replace the old seed labels with the network predictions, without any filtering (or confidence thresholding), correct?

@YurongYou
Copy link
Owner

Yes, you are correct!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants