Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add the possibility to export to mp3 #29

Open
TheMelancholyOfGigi198 opened this issue Jul 14, 2024 · 3 comments
Open

Add the possibility to export to mp3 #29

TheMelancholyOfGigi198 opened this issue Jul 14, 2024 · 3 comments
Labels
enhancement A new feature or feature improvement
Milestone

Comments

@TheMelancholyOfGigi198
Copy link

It would be convenient to be able to export directly from Bosca Ceoil in .mp3 format, so as not to have to convert the online format every time

@YuriSizov YuriSizov added the enhancement A new feature or feature improvement label Jul 14, 2024
@YuriSizov
Copy link
Owner

I'll have to look into the legal status of MP3 support. Unlike currently supported formats, it may be rather murky. And we probably need to use some 3rd party library for this, can't do compression like that by hand in GDScript.

@TerryCavanagh
Copy link

TerryCavanagh commented Jul 23, 2024

I thought about this a bit for the original Bosca - the easiest way to do it is to do what Audacity does and just provide a path to an external copy of LAME, and then just call it on the command line with whatever arguments you specify in an editor. E.g. what RazorLame does:

Though, actually, I'm pretty sure the MP3 patent has expired now, so it might be possible to do better than that! (probably this would need a more thorough investigation - again I'd check to see what Audacity have decided on the issue)

@Disonantemus
Copy link

128kb and lower, Opus is better, with better sound, good browser and OS support (maybe OGG), no license problems. Is used en Webm container (youtube) as a free alternative to AAC.


Above 128kb is considered "transparent", because just a few people (statistically) with very good hearing and very expensive gear can distinguish between original and encoded (using scientific principles). Blind Listening Tests


Is very easy to encode WAV output to almost anything with a bash one liner (using ffmpeg, opusenc, lame, etc).

@YuriSizov YuriSizov added this to the 3.2 milestone Dec 23, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement A new feature or feature improvement
Projects
None yet
Development

No branches or pull requests

4 participants