Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Keep the selected items order after export #533

Merged
merged 4 commits into from
Aug 24, 2020

Conversation

heitara
Copy link
Contributor

@heitara heitara commented Aug 4, 2020

No description provided.

@Ludotrico
Copy link

Not sure if you saw my comment on the other thread so:

@heitara thank you for investigating! I just pasted your changes in my project that is currently running the up to date version of the master. Unfortunately the problem persists. Images seem to always be placed before videos, disregarding order.

https://youtu.be/LonRlghD8-w

@heitara
Copy link
Contributor Author

heitara commented Aug 5, 2020

I saw that. I'll test again tomorrow again and will send video if it works on my end.

@heitara
Copy link
Contributor Author

heitara commented Aug 16, 2020

@Ludotrico I've double checked the version in the branch and it keeps the order of the items. I'm picking image, then video, and so on. I have a screen reccodring that proves it but I can send it directly to you. Could you double check that you are building from the correct repo/branch?

Could you paste the console output from the example app - This is what I get once I finalize the selection:
YPAssetZoomableView >>> No image 🧀 photo(p: YPImagePicker.YPMediaPhoto) 🧀 video(v: YPImagePicker.YPMediaVideo) 🧀 photo(p: YPImagePicker.YPMediaPhoto) 🧀 video(v: YPImagePicker.YPMediaVideo) 🧀 photo(p: YPImagePicker.YPMediaPhoto) 🧀 video(v: YPImagePicker.YPMediaVideo) 🧀 photo(p: YPImagePicker.YPMediaPhoto) 🧀 video(v: YPImagePicker.YPMediaVideo) 🧀 photo(p: YPImagePicker.YPMediaPhoto) 🧀 video(v: YPImagePicker.YPMediaVideo) Picker deinited 👍

@Ludotrico
Copy link

Ludotrico commented Aug 16, 2020

@heitara Thanks for the reply, this is in my pod-file for my app:

pod 'YPImagePicker', :git => 'https://github.com/heitara/YPImagePicker.git'

Unfortunately, it does not build.

Screen Shot 2020-08-16 at 4 37 12 PM

@heitara
Copy link
Contributor Author

heitara commented Aug 16, 2020

You have to add , :branch => 'feature/issue-488' to specify the branch.

@Ludotrico
Copy link

Great work @heitara ! I can confirm that the order is now preserved. What was the issue?

@heitara
Copy link
Contributor Author

heitara commented Aug 17, 2020

Once all assets are exported those are not sorted again. Like we discussed earlier each asset takes different time to be exported, this is why images were always before the video files. We should merge the fix now. cc @NikKovIos @s4cha

@Ludotrico
Copy link

@s4cha @NikKovIos it has been a week, can you please merge @heitara's branch?

Source/Pages/Gallery/YPLibraryVC.swift Outdated Show resolved Hide resolved
Source/Pages/Gallery/YPLibraryVC.swift Outdated Show resolved Hide resolved
Source/Pages/Gallery/YPLibraryVC.swift Outdated Show resolved Hide resolved
@NikKovIos NikKovIos merged commit 0c220e4 into Yummypets:master Aug 24, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants