-
-
Notifications
You must be signed in to change notification settings - Fork 982
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Keep the selected items order after export #533
Conversation
Not sure if you saw my comment on the other thread so: @heitara thank you for investigating! I just pasted your changes in my project that is currently running the up to date version of the master. Unfortunately the problem persists. Images seem to always be placed before videos, disregarding order. |
I saw that. I'll test again tomorrow again and will send video if it works on my end. |
@Ludotrico I've double checked the version in the branch and it keeps the order of the items. I'm picking image, then video, and so on. I have a screen reccodring that proves it but I can send it directly to you. Could you double check that you are building from the correct repo/branch? Could you paste the console output from the example app - This is what I get once I finalize the selection: |
@heitara Thanks for the reply, this is in my pod-file for my app:
Unfortunately, it does not build. |
You have to add |
Great work @heitara ! I can confirm that the order is now preserved. What was the issue? |
Once all assets are exported those are not sorted again. Like we discussed earlier each asset takes different time to be exported, this is why images were always before the video files. We should merge the fix now. cc @NikKovIos @s4cha |
@s4cha @NikKovIos it has been a week, can you please merge @heitara's branch? |
No description provided.